Fix _readyCheck INFO parser's handling of colon characters #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue which would occur when encountering INFO response field values containing the colon character. Because the parser logic splits entire lines upon colon character delimiters and took only the first component as the field name, and second component as the field value, any line containing multiple colons would ultimately lead to an incorrectly truncated field value. For example: "config_file:Y:\\redis\\redis.conf" Would be split into: ["config_file", "Y", "\\redis\\redis.conf"] Leading to a field name of "config_file" and an incorrect field value of "Y". The resolution is simply to handle additional field value components as needed, joining them together appropriately.
ioredis-robot
pushed a commit
that referenced
this pull request
May 30, 2020
## [4.17.2](v4.17.1...v4.17.2) (2020-05-30) ### Bug Fixes * _readyCheck INFO parser's handling of colon characters ([#1127](#1127)) ([38a09e1](38a09e1))
|
🎉 This PR is included in version 4.17.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this pull request
Mar 1, 2024
## [4.17.2](redis/ioredis@v4.17.1...v4.17.2) (2020-05-30) ### Bug Fixes * _readyCheck INFO parser's handling of colon characters ([#1127](redis/ioredis#1127)) ([38a09e1](redis/ioredis@38a09e1))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This super simple PR fixes #1126, an issue which occurs when encountering
INFOresponse field values containing the colon character.The purpose of this patch is to have the exposed
serverInfoclient property fully conformant with potential unexpected values Redis can respond with.I understand that the
serverInfoproperty is not documented, though it has apparently come into direct use by external libraries. I'm curious what the official stance on this is, and if this should be considered a valid practice or rather a misstep.