-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to set SSL verify mode #1085
Make it possible to set SSL verify mode #1085
Conversation
4c8872a
to
a54767d
Compare
I'm not opposed to this in principle, as it does provide quite a bit of convenience. Presently there's quite a bit of boilerplate involved when you're just testing a TLS connection and you don't want/have peer verification. That said, if we do add a simple options struct, perhaps we should also incorporate other simple options, such as one that would call @yossigo let me know if you have any thoughts. |
@michael-grunder I'm not against that either, but slightly concerned about not ending up wrapping too much of OpenSSL. Ideally, we should be able to draw a line and define what capabilities we provide for convenience and what is out of scope and requires users to handle their OpenSSL context. |
Another alternative would be to access the |
@stanhu There's already |
@yossigo |
If you don't mind making the aesthetic change, I will get this merged and we can determine later if we want to extend the options at all. |
If no SSL certificates are provided, many Redis clients default to disabling SSL peer verification. Previously it was a bit cumbersome to configure this because the client would either have to reimplement `redisCreateSSLContext()` or reach into the internals to set the OpenSSL verify mode. We can improve the SSL API by introducing a `redisCreateSSLContextWithOptions()` call that takes into structured parameters for SSL initialization. This structure contains a verify mode that is used to set the OpenSSL verify mode. Relates to redis#646
a54767d
to
71119a7
Compare
If no SSL certificates are provided, many Redis clients default to
disabling SSL peer verification. Previously it was a bit cumbersome to
configure this because the client would either have to reimplement
redisCreateSSLContext()
or reach into the internals to set theOpenSSL verify mode.
We can improve the SSL API by introducing a
redisCreateSSLContextWithOptions()
call that takes into structuredparameters for SSL initialization. This structure contains a verify
mode that is used to set the OpenSSL verify mode.
Relates to #646