-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump hiredis to v1.0.0 #69
Conversation
@rafaelfranca @michael-grunder can it please get some love. Thank you so much! |
I have the ability to merge this PR and am happy to do so. That said, I know next to nothing about Ruby so may need some help with any issues that may arise after we merge. |
@michael-grunder can we get this merge first then we can update to 1.0.2 |
Merged, thank you. |
@michael-grunder Do you need help with maintaining this project? I'd like to help. I see that hiredis has not had a Ruby release since 2018. A number of us at GitLab are interested in using hiredis in production, but without SSL support in an actual release we're going to hold off. |
Hi, @stanhu, that would be great! I'm happy to facilitate the releases (merging PRs, tagging, etc) and can help with any changes that are required in upstream hiredis, but I have almost no knowledge of Ruby at all, so some added expertise there would be fantastic. |
@michael-grunder Great! Could you tag a release to start? I think #59 is pretty important as well, but we should probably re-trigger CI if available. |
Sure, I can do that over the weekend. |
I suppose a 1.0.0 release should actually support SSL: #58 |
Yeah, it would seem prudent 😄. I honestly forgot about taking a crack at the implementation. Also, I've requested that the folks at Redis Inc add you as a maintainer to this project. I think @chayim might be taking point on that. |
According to hiredis readme, there's only a handful of breaking changes.
https://github.com/redis/hiredis/blob/297f6551da11d4a22fefe4d385d42edf27a6cd73/README.md
This PR: