Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hiredis to v1.0.0 #69

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Conversation

artygus
Copy link
Contributor

@artygus artygus commented Oct 21, 2020

According to hiredis readme, there's only a handful of breaking changes.

https://github.com/redis/hiredis/blob/297f6551da11d4a22fefe4d385d42edf27a6cd73/README.md

IMPORTANT: Breaking changes from 0.14.1 -> 1.0.0

redisContext has two additional members (free_privdata, and privctx).
redisOptions.timeout has been renamed to redisOptions.connect_timeout, and we've added redisOptions.command_timeout.
redisReplyObjectFunctions.createArray now takes size_t instead of int for its length parameter.

This PR:

  • bumps hiredis to the head of v1.0.0 tag
  • stubs RESP3 protocol reply functions (double and bool)
  • updates createArrayObject signature

@ssinghi
Copy link

ssinghi commented Sep 26, 2021

@rafaelfranca @michael-grunder can it please get some love. Thank you so much!

@michael-grunder
Copy link
Collaborator

I have the ability to merge this PR and am happy to do so.

That said, I know next to nothing about Ruby so may need some help with any issues that may arise after we merge.

@kimyu92
Copy link

kimyu92 commented Oct 28, 2021

@michael-grunder can we get this merge first then we can update to 1.0.2

@michael-grunder michael-grunder merged commit a66f527 into redis:master Oct 29, 2021
@michael-grunder
Copy link
Collaborator

Merged, thank you.

@artygus artygus deleted the bump-hiredis-to-v1 branch October 29, 2021 06:40
@stanhu
Copy link
Contributor

stanhu commented Aug 5, 2022

@michael-grunder Do you need help with maintaining this project? I'd like to help. I see that hiredis has not had a Ruby release since 2018. A number of us at GitLab are interested in using hiredis in production, but without SSL support in an actual release we're going to hold off.

@michael-grunder
Copy link
Collaborator

Hi, @stanhu, that would be great!

I'm happy to facilitate the releases (merging PRs, tagging, etc) and can help with any changes that are required in upstream hiredis, but I have almost no knowledge of Ruby at all, so some added expertise there would be fantastic.

@stanhu
Copy link
Contributor

stanhu commented Aug 5, 2022

@michael-grunder Great! Could you tag a release to start? I think #59 is pretty important as well, but we should probably re-trigger CI if available.

@michael-grunder
Copy link
Collaborator

Sure, I can do that over the weekend.

@stanhu
Copy link
Contributor

stanhu commented Aug 9, 2022

I suppose a 1.0.0 release should actually support SSL: #58

@michael-grunder
Copy link
Collaborator

Yeah, it would seem prudent 😄. I honestly forgot about taking a crack at the implementation.

Also, I've requested that the folks at Redis Inc add you as a maintainer to this project. I think @chayim might be taking point on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants