Added Python 3.12 to test matrix and classifiers #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You may want to consider updating cibuildwheel as well - I think at least v2.16.2 is needed to build cp312 wheels. IMHO it's a good idea to include this with your PR since you also declare Python 3.12 support, so it'd a bit strange if it'd still do a release without the proper wheels. |
|
Makes indeed no sense @ThiefMaster, thanks for pointing out! I updated the pull-request. |
chayim
reviewed
Dec 13, 2023
.github/workflows/integration.yaml
Outdated
| @@ -25,7 +25,7 @@ jobs: | |||
| strategy: | |||
| max-parallel: 15 | |||
| matrix: | |||
| python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', 'pypy-3.7', 'pypy-3.8'] | |||
| python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12', 'pypy-3.7', 'pypy-3.8'] | |||
There was a problem hiding this comment.
Let's add pypy-3.9 while here, WDYT?
There was a problem hiding this comment.
Feel free to commit, I have no objection.
|
Just the one comment @foarsitter. I'm happy to push to it, if you prefer. |
|
Thanks @chayim! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.