-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing broken windows builds on python < 3.8 #151
Merged
Merged
+18
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prokazov
commented
Jan 31, 2023
- Removed Bsymbolic option from linker args
- Fixed(work-arounded) a build break on x86 Windows/old-ish Pythons builds caused by https://bugs.python.org/issue11717.
2) Fix a possible crash when running in Redis Gears.
2) Reverted version bump. 3) Added an entry to the changelog.
2) Reverted version bump. 3) Added an entry to the changelog.
2) add egg-info to gitignore
2) Fix a build break on x86 platforms
chayim
approved these changes
Feb 1, 2023
chayim
changed the title
Fixes for pack_command
Fixing broken windows builds on python < 3.8
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.