-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pack_command to support writing via hiredis-py #147
Conversation
2) Fix a possible crash when running in Redis Gears.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big fan, very small changes. Any chance you've finished up on the redis-py PR we were discussing that shows covered usage?
2) Reverted version bump. 3) Added an entry to the changelog.
2) Reverted version bump. 3) Added an entry to the changelog.
|
I mean I tested the redis-py with the new pack_command locally, but its CI/CD actions target the stock hiredis-py. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes, as per Bsymbolic build fails
@chayim I pushed a commit with conditional flags. Can you re-run the CI? Are there any wheels built not covered by the CI? I excluded win and darwin platforms which don't support the flag. The CI failure of the ubuntu on 3.7 seemed unrelated. |
2) add egg-info to gitignore
Looks great. Given a past bug, I just added #148. I'll merge that into your branch, and see it through. If we're good there, we're ready to merge! |
As of now, hiredis-py only exposes Reader functionality, that helps to speed up the RESP deserialization.
pack_command serializes redis-py command (tuple of str, bytes, int or float) to a bytes object with the RESP representation of the command.