Restores publishing of source distribution #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chayim I do hate to ping, but I think this would be beneficial to a number of people |
|
@stumpylog I'm thankful for the ping! I missed this in the millions of GitHub notifs. Apologies - on modernizing a bunch of other things, it looks like I missed this. |
chayim
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a job to the publish action which creates the sdist for publishing to pypi. This allows support of more architectures and OSes which need to build the package.
The action runs to completion, until the actual publish step, as I can't really test that, but I expect it would work fine. See https://github.com/stumpylog/hiredis-py/actions/runs/3795414052
Fixes #138