Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test case for CLIENT KILL with MAXAGE option #2971

Merged
merged 11 commits into from
Jun 19, 2024
Merged

Added test case for CLIENT KILL with MAXAGE option #2971

merged 11 commits into from
Jun 19, 2024

Conversation

vladvildanov
Copy link
Collaborator

Closes #2920

@vladvildanov vladvildanov self-assigned this Apr 15, 2024
monkey92t
monkey92t reviewed Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@monkey92t monkey92t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, we need to change the test Redis version to the unstable branch.

https://github.com/redis/redis/tree/unstable

@monkey92t
Copy link
Collaborator

The parameter has not been released in the stable version.

@vladvildanov
Copy link
Collaborator Author

@monkey92t Yeah, I got it. I'll work on this 👌

@vladvildanov
Copy link
Collaborator Author

@ofekshenawa Does tests fails because not supported or any other reason?

@ofekshenawa
Copy link
Collaborator

@vladvildanov yes, currently it's not supported.

@ofekshenawa ofekshenawa merged commit 0777247 into redis:master Jun 19, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monkey92t monkey92t monkey92t left review comments

@ofekshenawa ofekshenawa ofekshenawa approved these changes

@gerzse gerzse Awaiting requested review from gerzse

Assignees

@vladvildanov vladvildanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add command filter for CLIENT KILL to support maximum age via [MAXAGE] option
3 participants
@vladvildanov @monkey92t @ofekshenawa