Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monitor on go 1.19 #2908

Merged
merged 9 commits into from
Mar 21, 2024
Merged

Fix monitor on go 1.19 #2908

merged 9 commits into from
Mar 21, 2024

Conversation

ofekshenawa
Copy link
Collaborator

@ofekshenawa ofekshenawa commented Feb 15, 2024

This PR fixes a data race issue in the monitor command.
Additionally, We are skipping the example tests because they contain dependencies not supported in Go v1.19

@ofekshenawa ofekshenawa marked this pull request as ready for review February 18, 2024 17:08
gerzse
gerzse previously approved these changes Mar 21, 2024
monitor_test.go Show resolved Hide resolved
command.go Outdated Show resolved Hide resolved
@ofekshenawa ofekshenawa merged commit 34dacf1 into master Mar 21, 2024
10 checks passed
@vmihailenco vmihailenco deleted the os-fix-monitor-datarace-in-119 branch April 17, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants