Add support for root_device_hints #553
Conversation
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 46s |
|
from change #553: |
|
from change #553: |
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 45s |
|
from change #553: |
|
from change #553: |
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 3m 10s |
|
from change #553: |
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 52s |
|
from change #553: |
|
from change #553: |
roles/generate_manifests/README.md
Outdated
| | extra_manifest_dir | $MANIFESTS_DIR/openshift | Yes | Path for extra manifests | | ||
| | static_network_config | {} | No | Static network config for every node | | ||
| | root_device_hints | {} | No | Device Hints per node | |
There was a problem hiding this comment.
could you include the doc for the root device hints you shared in the conversation, I think is quite useful to understand how to use that variable
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 51s |
|
from change #553: |
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 45s |
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 56s |
|
from change #553: |
|
from change #553: |
roles/generate_manifests/README.md
Outdated
| | static_network_config | {} | No | Static network config for every node | | ||
| | installation_disk_path | | No | Disk to use for install if you don't want the first found disk | | ||
| | root_device_hints | {} | No | Install device hints per node, in case installation_disk_path is not enough | |
There was a problem hiding this comment.
would it be useful to link to documentation describing what hints are available?
|
from change #553:
|
1 similar comment
|
from change #553:
|
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 49s |
roles/generate_manifests/README.md
Outdated
| ``` | ||
|
|
||
| [^1]: As per the [OCP 4.17 docs](https://docs.redhat.com/en/documentation/openshift_container_platform/4.17/html-single/installing_an_on-premise_cluster_with_the_agent-based_installer/index#installing-ocp-agent-inputs_installing-with-agent-based-installer) |
There was a problem hiding this comment.
nit:
| [^1]: As per the [OCP 4.17 docs](https://docs.redhat.com/en/documentation/openshift_container_platform/4.17/html-single/installing_an_on-premise_cluster_with_the_agent-based_installer/index#installing-ocp-agent-inputs_installing-with-agent-based-installer) | |
| [^1]: As per the [OCP 4.17 docs](https://docs.redhat.com/en/documentation/openshift_container_platform/4.17/html-single/installing_an_on-premise_cluster_with_the_agent-based_installer/index#root-device-hints_preparing-to-install-with-agent-based-installer) |
|
from change #553:
|
1 similar comment
|
from change #553:
|
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 43s |
|
from change #553:
|
1 similar comment
|
from change #553:
|
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 58s |
The root device hints are independent from the static network configuration. Keep backwards compatibility with installation_disk_path, if you specify the installation_disk_path then a device hint is added, if you specify a dictionary then the root hints are added as k/v pairs TestBos2: abi TestBos2Sno: abi-sno
Co-authored-by: Tony Garcia <[email protected]>
thekad
force-pushed
the
root_device_hints
branch
from
7cd4b2a to
4574330
Compare
|
from change #553:
|
1 similar comment
|
from change #553:
|
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 54s |
SUMMARY
There is no code path that uses
installation_disk_pathin the OCP agent, adding support forroot_device_hintsISSUE TYPE
Tests
Despite the failure the sno cluster was installed, the install info, shows the rendering of the template is as expected
This job failed as expected as the device root used does not exist in the server.
Test-Hints: no-check