Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preflight: Update the role to be able to run with dci container #508

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Preflight: Update the role to be able to run with dci container #508

wants to merge 3 commits into from
+13 −2

Conversation

pierreblanc
Copy link
Contributor

@pierreblanc pierreblanc commented Dec 16, 2024 •
edited
Loading

SUMMARY

With dci in container, the source is localhost which is not the jumphost.

  • We must do these copies from the jumphost with 'remote_src'.
  • Remove 'with_fileglob' which is executed in the control server.
ISSUE TYPE
  • Bug (with dci-podman)

@pierreblanc pierreblanc requested a review from a team as a code owner December 16, 2024 18:08
@dcibot
Copy link
Collaborator

dcibot commented Dec 16, 2024

from change #508:

  • no check (not a code change)

1 similar comment
@dcibot
Copy link
Collaborator

dcibot commented Dec 16, 2024

from change #508:

  • no check (not a code change)

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/0f1823f0854f4957a201dd60df656ff2

✔️ dci-rpm-build-el8 SUCCESS in 4m 03s
✔️ dci-rpm-build-el9 SUCCESS in 3m 34s

@dcibot
Copy link
Collaborator

dcibot commented Dec 16, 2024

from change #508:

  • no check (not a code change)

1 similar comment
@dcibot
Copy link
Collaborator

dcibot commented Dec 16, 2024

from change #508:

  • no check (not a code change)

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/8762b54585e54dcdb3b1b6d7ff21de09

✔️ dci-rpm-build-el8 SUCCESS in 2m 49s
✔️ dci-rpm-build-el9 SUCCESS in 2m 51s

@dcibot
Copy link
Collaborator

dcibot commented Dec 16, 2024

from change #508:

  • no check (not a code change)

1 similar comment
@dcibot
Copy link
Collaborator

dcibot commented Dec 16, 2024

from change #508:

  • no check (not a code change)

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/3cf422a4c2314320a4d9ef26fe1f2a7b

✔️ dci-rpm-build-el8 SUCCESS in 2m 44s
✔️ dci-rpm-build-el9 SUCCESS in 3m 01s

@dcibot
Copy link
Collaborator

dcibot commented Dec 17, 2024

from change #508:

@ramperher
Copy link
Contributor

@pierreblanc , can we specify in the PR title that we're targeting preflight role in this change?

@pierreblanc pierreblanc changed the title Copy tasks must be executed from the jumphost with dci container Preflight: Copy tasks must be executed from the jumphost with dci container Dec 19, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/d932eb2c38bf4be7a3f58940c3284a12

✔️ dci-rpm-build-el8 SUCCESS in 2m 48s
✔️ dci-rpm-build-el9 SUCCESS in 2m 22s

@pierreblanc pierreblanc changed the title Preflight: Copy tasks must be executed from the jumphost with dci container Preflight: Update the role to be able to run with dci container Dec 19, 2024
@dcibot
Copy link
Collaborator

dcibot commented Dec 19, 2024

from change #508:

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/4711d6c6079141fc8dd8990df006f048

✔️ dci-rpm-build-el8 SUCCESS in 2m 43s
✔️ dci-rpm-build-el9 SUCCESS in 2m 20s

@dcibot
Copy link
Collaborator

dcibot commented Dec 19, 2024

from change #508:

ramperher
ramperher approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@ramperher ramperher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tkrishtop
tkrishtop approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@tkrishtop tkrishtop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pierreblanc LGTM

@dcibot
Copy link
Collaborator

dcibot commented Jan 6, 2025

from change #508:

@dcibot
Copy link
Collaborator

dcibot commented Jan 6, 2025

from change #508:

@dcibot
Copy link
Collaborator

dcibot commented Jan 6, 2025

from change #508:

@dcibot
Copy link
Collaborator

dcibot commented Jan 6, 2025

from change #508:

@dcibot
Copy link
Collaborator

dcibot commented Jan 6, 2025

from change #508:

@dcibot
Copy link
Collaborator

dcibot commented Jan 7, 2025

from change #508:

@dcibot
Copy link
Collaborator

dcibot commented Jan 7, 2025

from change #508:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkrishtop tkrishtop tkrishtop approved these changes

@ramperher ramperher ramperher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pierreblanc @dcibot @ramperher @tkrishtop