Setup role for the Router Advertisement Daemon or radvd #490
Conversation
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 46s |
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 43s |
There was a problem hiding this comment.
Hi @cwilkers , thanks for your contribution! Some general advices below:
- You need to review the logs from the ansible-lint check, that is currently failing. There you will find some regressions that you need to fix:
## Regressions from main branch:
-ERROR: roles/setup_radvd/tasks/main.yaml:: package-latest: Package installs should not use latest.
-ERROR: roles/setup_radvd/tasks/pre-requisites.yaml:: yaml[new-line-at-end-of-file]: No new line character at the end of file
- For testing, ideally we test it with DCI, but in this case, since it's a new role that is not really related to DCI lifecycle, if you can provide some logs with a local execution you may run in your environment, it should be good.
- In the meantime, if no DCI job is meant to be run, please add
Test-Hints: no-checkto your PR description, so that the DCI check will be omitted
- In the meantime, if no DCI job is meant to be run, please add
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 44s |
|
recheck |
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 48s |
|
recheck |
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 53s |
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 46s |
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 3m 05s |
There was a problem hiding this comment.
LGTM, reviewed also some logs shared privately and the execution looks good.
@cwilkers , with regards to the PR, we will only need you to squash all your commits to have one single commit, then we can review what's going on with the sanity checks that are currently failing.
- Updated README with radvd role - Uses indepent setup_radvd named variables
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 45s |
|
Just recheck after merging #494, which includes the fix for the sanity checks. |
|
retest |
|
from change #490: |
SUMMARY
Adds a role that installs the router advertisement daemon (radvd) that is a necessary component of dhcpv6 non SLAAC ipv6 deployments.
ISSUE TYPE
Tests
If existing labs use SLAAC or no ipv6, it may not be advised to test this module in those labs until we can inspect their configuration.
TestBos2Sno: sno