Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve templating #487

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Improve templating #487

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a6f916
Improve templating
tonyskapunk Nov 13, 2024
09ef6a5
Add hybrid pool
tonyskapunk Nov 14, 2024
e920d6a
Update .github/PULL_REQUEST_TEMPLATE.md
tonyskapunk Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 20 additions & 16 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,38 @@
##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->

<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
<!-- Describe the change, including rationale and design decisions -->

<!-- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->

##### ISSUE TYPE

<!--- Pick one below and delete the other: -->
<!-- Pick one below and delete the other: -->
- Bug, Docs Fix or other nominal change
- New or Enhanced Feature

##### Tests

<!--- Document the tests for this change, if any -->
<!--- See: https://github.com/redhatci/ansible-collection-redhatci-ocp/blob/main/CONTRIBUTING.md#ci-pipelines -->
<!-- Document the tests for this change, if any -->
<!-- See: https://github.com/redhatci/ansible-collection-redhatci-ocp/blob/main/CONTRIBUTING.md#ci-pipelines -->

<!--- Examples:
- [] TestDallas - <JobID>
- [] TestDallasWorkload - <JobID>
- [] TestBos2 - <JobID>
- [] TestBos2Sno - <JobID>
- [] TestBos2SnoBaremetal - <JobID>
--->
<!-- Examples:
- [ ] TestDallas: ocp-4.17-vanilla - <JobURL>
- [ ] TestDallasHybrid: ocp-4.17-vanilla - <JobURL>
tonyskapunk marked this conversation as resolved.
Show resolved Hide resolved
- [ ] TestDallasWorkload: preflight-green - <JobURL>
- [ ] TestBos2: virt - <JobURL>
- [ ] TestBos2Sno: sno - <JobURL>
- [ ] TestBos2SnoBaremetal: sno - <JobURL>
-->

---

<!--- Include the test and dependencies for this change -->
<!-- See: https://github.com/redhatci/ansible-collection-redhatci-ocp/blob/main/CONTRIBUTING.md#ci-pipelines >
<!-- Include the test and dependencies for this change -->
<!-- See: https://github.com/redhatci/ansible-collection-redhatci-ocp/blob/main/CONTRIBUTING.md#ci-pipelines -->


<!-- Examples:

<!--- Example:
Test-Hint: no-check
Depends-on: https://path/to/depending/change

Depends-on: https://...
-->
1 change: 1 addition & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ The collection has multiple CI pipelines that run on every PR:
To specify which DCI lab to use and which resources to use, you can use the following strings in the descrption of the PR:

* `TestDallas`: baremetal clusters in the Dallas lab.
* `TestDallasHybrid`: hybrid clusters with a virtualized control-plane in the Dallas Lab.
* `TestDallasWorkload`: workload on a pre-installed baremetal cluster in Dallas.
* `TestBos2`: virtual setup in the BOS2 lab.
* `TestBos2Sno`: virtual SNO setup in the BOS2 lab.
Expand Down