Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-49495) generator: "uninline" generator_open_unit_file and generator_add_symlink #287

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Jul 17, 2024

Inlining of these functions changed ABI of libsystemd-shared which causes issue on update when generators packaged in systemd-udev subpackage fail to execute because of ABI change. systemd and the library are already updated while systemd-udev subpackage is not and hence old generators can't be started when systemd is reexecuting due to internal library incompatibility.

rhel-only: bugfix

Resolves: RHEL-49495

Inlining of these functions changed ABI of libsystemd-shared which
causes issue on update when generators packaged in systemd-udev
subpackage fail to execute because of ABI change. systemd and the
library are already updated while systemd-udev subpackage is not and
hence old generators can't be started when systemd is reexecuting
due to internal library incompatibility.

rhel-only: bugfix

Resolves: RHEL-49495
@jamacku jamacku requested a review from msekletar July 17, 2024 13:29
@github-actions github-actions bot changed the title generator: "uninline" generator_open_unit_file and generator_add_symlink (RHEL-49495) generator: "uninline" generator_open_unit_file and generator_add_symlink Jul 17, 2024
@github-actions github-actions bot added tracker/invalid-product pr/needs-ci Formerly needs-ci pr/needs-review Formerly needs-review labels Jul 17, 2024
Copy link

github-actions bot commented Jul 17, 2024

Commit validation

Tracker - RHEL-49495

The following commits meet all requirements

commit upstream
1d28245 - generator: "uninline" generator_open_unit_file and generator_add_symli… rhel-only: bugfix

Tracker validation

Success

🟢 Tracker RHEL-49495 has set desired product: rhel-9.4.z
🟢 Tracker RHEL-49495 has set desired component: systemd
🟢 Tracker RHEL-49495 has been approved


Pull Request validation

Success

🟢 CI - All checks have passed
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved


Auto Merge

Failed

🔴 Pull Request has unsupported target branch rhel-9.4.0, expected branches are: 'main,master'

Success

🟢 Pull Request is not marked as draft and it's not blocked by dont-merge label
🟢 Pull Request meet requirements, title has correct form
🟢 Pull Request meet requirements, mergeable is true
🟢 Pull Request meet requirements, mergeable_state is clean

Copy link
Member

@msekletar msekletar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added pr/needs-manual-merge Formerly pr/needs-manual-merge and removed pr/needs-ci Formerly needs-ci pr/needs-review Formerly needs-review labels Jul 17, 2024
@jamacku jamacku merged commit 657e89e into redhat-plumbers:rhel-9.4.0 Jul 18, 2024
29 checks passed
@jamacku jamacku deleted the generators branch July 18, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants