Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IBM OCP installer configuration variables #997

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update IBM OCP installer configuration variables #997

wants to merge 1 commit into from

Conversation

ebattat
Copy link
Collaborator

@ebattat ebattat commented Mar 10, 2025 •
edited by RobertKrawitz
Loading

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

Update IBM OCP installer configuration variables: OCP_BUILD and INSTALLER_VAR_PATH. Required by JetLag change redhat-performance/jetlag#625

For security reasons, all pull requests need to be approved first before running any automated CI

@ebattat ebattat added bug Something isn't working enhancement New feature or request labels Mar 10, 2025
@ebattat ebattat requested a review from RobertKrawitz March 10, 2025 06:41
@ebattat ebattat self-assigned this Mar 10, 2025
RobertKrawitz
RobertKrawitz reviewed Mar 10, 2025
View reviewed changes
Copy link
Member

@RobertKrawitz RobertKrawitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume these are used by the the builder image. I don't see any corresponding changes in the dockerfile or anything?

@ebattat
Copy link
Collaborator Author

ebattat commented Mar 10, 2025

Yes, its according to jetlag changes: redhat-performance/jetlag#625

@RobertKrawitz
Copy link
Member

Yes, its according to jetlag changes: redhat-performance/jetlag#625

OK, I've updated the description accordingly and will approve. Please do that in the future when changes are required by outside changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertKrawitz RobertKrawitz RobertKrawitz approved these changes

Assignees

@ebattat ebattat

Labels
bug Something isn't working enhancement New feature or request
Projects
benchmark-runner
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebattat @RobertKrawitz