Add a new option -V to verify installed policies #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjeanner
force-pushed
the
verify-policies
branch
5 times, most recently
from
76e1655 to
d3a3ac6
Compare
jpichon
reviewed
Jun 13, 2022
cjeanner
force-pushed
the
verify-policies
branch
from
d3a3ac6 to
5962e5c
Compare
lhh
reviewed
Jun 13, 2022
cjeanner
force-pushed
the
verify-policies
branch
2 times, most recently
from
f7af77d to
17509c9
Compare
lhh
requested changes
Jun 13, 2022
cjeanner
force-pushed
the
verify-policies
branch
from
17509c9 to
45b0b05
Compare
jpichon
reviewed
Jun 15, 2022
This new parameter will help ensuring the package did properly install. It will ensure we're on an SELinux enabled, Enforcing system, then loop on the different $MODULES to ensure they are present on the system. In the end, this will help ensuring the package is properly installed, avoiding future hide'n'seek parties when we're seeing any weird SELinux issues within TripleO.
cjeanner
force-pushed
the
verify-policies
branch
from
45b0b05 to
af18066
Compare
jpichon
approved these changes
Jun 15, 2022
rdoproject
pushed a commit
to rdo-packages/openstack-selinux-distgit
that referenced
this pull request
Jun 15, 2022
This will allow to ensure the policies are correctly installed, by calling `rpm -V openstack-selinux'. The "local_settings.sh -V" is introduced by the following patch: redhat-openstack/openstack-selinux#93 Change-Id: I7a4cf3da16cddddcadac5658207958878ff618dc
cjeanner
added a commit
to cjeanner/openstack-selinux
that referenced
this pull request
Jun 16, 2022
`rpm -V' filters this out and displays only stderr content, so we'd be missing the important bits of the verification. With this patch in, the command outputs the list of missing modules, the amount of them, and the final, default rpm verification failure message. This patch is a follow-up of redhat-openstack#93
cjeanner
added a commit
to cjeanner/openstack-selinux
that referenced
this pull request
Jun 16, 2022
`rpm -V' filters the output and displays only stderr content, so we'd be missing the important bits of the verification. With this patch in, the command outputs the list of missing modules, the amount of them, and the final, default rpm verification failure message. This patch is a follow-up of redhat-openstack#93
cjeanner
added a commit
to cjeanner/openstack-selinux
that referenced
this pull request
Jun 20, 2022
`rpm -V' filters the output and displays only stderr content, so we'd be missing the important bits of the verification. With this patch in, the command outputs the list of missing modules, the amount of them, and the final, default rpm verification failure message. This patch is a follow-up of redhat-openstack#93
rdoproject
pushed a commit
to rdo-packages/openstack-selinux-distgit
that referenced
this pull request
Jul 8, 2022
This will allow to ensure the policies are correctly installed, by calling `rpm -V openstack-selinux'. The "local_settings.sh -V" is introduced by the following patch: redhat-openstack/openstack-selinux#93 Resolves: rhbz#2095776 Change-Id: I7a4cf3da16cddddcadac5658207958878ff618dc
rdoproject
pushed a commit
to rdo-packages/openstack-selinux-distgit
that referenced
this pull request
Jul 8, 2022
This will allow to ensure the policies are correctly installed, by calling `rpm -V openstack-selinux'. The "local_settings.sh -V" is introduced by the following patch: redhat-openstack/openstack-selinux#93 Change-Id: I7a4cf3da16cddddcadac5658207958878ff618dc (cherry picked from commit f4df752)
rdoproject
pushed a commit
to rdo-packages/openstack-selinux-distgit
that referenced
this pull request
Jul 8, 2022
This will allow to ensure the policies are correctly installed, by calling `rpm -V openstack-selinux'. The "local_settings.sh -V" is introduced by the following patch: redhat-openstack/openstack-selinux#93 Change-Id: I7a4cf3da16cddddcadac5658207958878ff618dc (cherry picked from commit f4df752)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new parameter will help ensuring the package did properly install.
It will ensure we're on an SELinux enabled, Enforcing system, then loop
on the different $MODULES to ensure they are present on the system.
In the end, this will help ensuring the package is properly installed,
avoiding future hide'n'seek parties when we're seeing any weird SELinux
issues within TripleO.