[CVP-3949] Add olm.skipRange and olm.replaces to parsed_operator_data #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nmars @samvarankashyap Could you please take a look? |
|
@yashvardhannanavati It would be nice to write some tests ideally positive and negative (e.g. with missing olm.replaces in metadata) |
yashvardhannanavati
force-pushed
the
olm_variables
branch
from
3c79835 to
a97ed68
Compare
good idea! Added it :) |
yashvardhannanavati
force-pushed
the
olm_variables
branch
2 times, most recently
from
5b068ef to
06ffd90
Compare
yashvardhannanavati
force-pushed
the
olm_variables
branch
from
06ffd90 to
3994892
Compare
|
/LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.