WIP Feature/cert pipeline #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-source
suggested changes
Nov 3, 2021
v2/hack/certify/certify.sh
Outdated
| cd $TMP_DIR/certified-operators-preprod | ||
| git add --all | ||
| git commit -m $VERSION | ||
| git push |
There was a problem hiding this comment.
Can you use branches or it has to be a main commit&push?
There was a problem hiding this comment.
they actually just changed the repo in the instructions, and the default branch was stage, now it is main
we can set this to our choice of branch, the git_branch is specified in the tekton run
let me know how you want to handle it
There was a problem hiding this comment.
Let's create a branch named for the release off the version and pass that. It'll let us keep stuff separate. Maybe at some point we can trigger actions on merge. If that's too complicated to do right now we can do follow on. First priority is a release of 2.4.0
zach-source
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To pass certification checks