Feature/watch owned resources #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yConfig however does respond
zach-source
suggested changes
May 4, 2020
Comment on lines
+199
to
+204
| url := fmt.Sprintf("%s/%s/%s/%s", instance.Spec.DeployConfig.IbmCosURL, instance.Spec.DeployConfig.BucketName, instance.Spec.ClusterUUID, instance.Spec.DeployConfig.ChildRSSFIleName) | ||
| instance.Spec.ChildUrl = &url | ||
| err = r.client.Update(context.TODO(), instance) | ||
| if err != nil { | ||
| reqLogger.Error(err, "Failed to update Status.RedHatMarketplaceSecretFound") | ||
| reqLogger.Error(err, "Failed to update ChildUrl") | ||
| return reconcile.Result{}, err |
There was a problem hiding this comment.
We can move this logic into the end of the reconcileRhmOperatorSecret.
There was a problem hiding this comment.
Thought about doing that. I was worried about having a partially formed url. As is, I know all the values are there and can create a full url. Is that an issue ?
There was a problem hiding this comment.
If you don't have any missing fields and you recalculate it each time the secret is found then by the time you get here the child url will be complete.
Co-authored-by: Zachary Taylor <[email protected]>
Co-authored-by: Zachary Taylor <[email protected]>
Co-authored-by: Zachary Taylor <[email protected]>
Co-authored-by: Zachary Taylor <[email protected]>
mxpaspa
pushed a commit
that referenced
this pull request
May 6, 2020
Namsimar: Operator deploys single
|
We've moved this work to the /owned PR |
zach-source
added a commit
that referenced
this pull request
Nov 22, 2021
zach-source
added a commit
that referenced
this pull request
Nov 22, 2021
chore: updating licenses chore: fixing cover error chore: fixing test chore: fixing test #2 chore: removing focus chore: fixing another test chore: fixing another test chore: fixing another test chore: adding test debug fix: making config not crash on bad k8s cfg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alteration of the my other pr which includes some refactoring.
Changes Made:
Remaining Items:
Change github references to use github.com/redhat-marketplace
Test whether adding ownership to the secret after it's found works
Check that I'm returning reconcole.Result{},err in the correct places
Issue with updating JobState
Make sure that legacy crd values are set to null/accounted for properly
Check that the Spec field and Status field descriptors are present and correct after merge with develop
Check that updates to: ClusterUUID, RazeeDashUrl, ChildRRS3FileName trigger an update tocorresponding Razee resources