Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a Localization rule set #688

Closed
wants to merge 1 commit into from
Closed

Create a Localization rule set #688

wants to merge 1 commit into from

Conversation

rolfedh
Copy link
Collaborator

@rolfedh rolfedh commented Nov 1, 2023 •
edited
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

Click here to review and test in web IDE: Contribute

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023 •
edited
Loading

🎊 Navigate the preview: https://redhat-documentation-vale-at-red-hat-688.surge.sh 🎊

This was referenced Nov 1, 2023
Closed
Open
@rolfedh rolfedh marked this pull request as draft November 1, 2023 19:01
@rolfedh rolfedh requested a review from myamamot November 1, 2023 19:04
@rolfedh
Copy link
Collaborator Author

rolfedh commented Nov 1, 2023 •
edited
Loading

FYI:

@rolfedh rolfedh requested a review from aireilly November 21, 2023 20:02
@aireilly
Copy link
Member

Layout looks fine to me.

aireilly
aireilly reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder would a metric rule be useful: https://vale.sh/docs/topics/styles/#metric

@aireilly
Copy link
Member

aireilly commented Jan 15, 2024 •
edited
Loading

To progress this new Localization rule set work, and to minimize confusion for VRH contributors, I propose the bulk of this work should happen in a separate repo, in the same manner that @rohennes and I worked on the AsciiDoc and OpenShift AsciiDoc rule sets: https://github.com/rohennes/vale-asciidoc

Once the new rule set is ready for wider adoption, it can be merged here. WDYT @rolfedh

cc @Chandralekha-RedHat

@rolfedh
Copy link
Collaborator Author

rolfedh commented Jan 15, 2024

I agree. That makes sense.

@rolfedh rolfedh closed this Jan 15, 2024
@aireilly
Copy link
Member

@Chandralekha-RedHat and I moved this work to https://github.com/reachlekha/vale-localization/tree/main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aireilly aireilly aireilly left review comments

@myamamot myamamot Awaiting requested review from myamamot

Assignees

@aireilly aireilly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a localization rule to highlight common errors that cause trouble for translators
2 participants
@rolfedh @aireilly