-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize the capitalization and short form of Red Hat Customer Portal #437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments :)
supplementary_style_guide/glossary_terms_conventions/general_conventions/r.adoc
Outdated
Show resolved
Hide resolved
supplementary_style_guide/glossary_terms_conventions/general_conventions/r.adoc
Outdated
Show resolved
Hide resolved
3977c0a
to
1e552be
Compare
supplementary_style_guide/glossary_terms_conventions/general_conventions/r.adoc
Outdated
Show resolved
Hide resolved
supplementary_style_guide/glossary_terms_conventions/general_conventions/r.adoc
Outdated
Show resolved
Hide resolved
1e552be
to
60429c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this!
Two pieces of feedback here, then also commented on an earlier review to add "portal" to the list of incorrect forms.
supplementary_style_guide/glossary_terms_conventions/general_conventions/r.adoc
Show resolved
Hide resolved
c9ed88f
to
9c53ba6
Compare
9c53ba6
to
95f1ca0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merging
Purpose: This PR standardizes the capitalization and short form of Red Hat Customer Portal.
Fixes #384
Request for Review:
@IngridT1, @mportman12, @bergerhoffer, @ndeevy, @bredamc - your insights and feedback on these changes would be greatly appreciated. Thank you.