Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the capability to bind RelaxNG schema #807

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

angelozerr
Copy link
Contributor

Provide the capability to bind RelaxNG schema

Signed-off-by: azerr [email protected]

@angelozerr angelozerr requested a review from datho7561 November 15, 2022 17:33
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very well, just found some code style stuff to nitpick about in the code.

src/commands/registerCommands.ts Outdated Show resolved Hide resolved
src/commands/registerCommands.ts Outdated Show resolved Hide resolved
@datho7561 datho7561 added the bug Something isn't working label Nov 16, 2022
@datho7561 datho7561 added this to the 0.23.0 milestone Nov 16, 2022
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Angelo!

@datho7561 datho7561 merged commit e1506e4 into redhat-developer:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants