Added permission check and window error message for LemMinx binary #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's actually nothing we can do to fix this on the build side for binaries uploaded using the upload/download actions : https://github.com/actions/upload-artifact#permission-loss . If we use that action, the binaries the binaries will always be without proper permissions. Update : Actually, the above isn't so bad. There's a different between an artifact uploaded to a Build and one uploaded to Releases. The build location is not meant for user consumption and is mainly for convenience. The Release location works just fine. I guess the above is just a good piece of information to be aware of. |
AlexXuChen
force-pushed
the
check-binary-permission-error
branch
from
b335e37 to
c9d61c1
Compare
AlexXuChen
force-pushed
the
check-binary-permission-error
branch
4 times, most recently
from
a6a24a9 to
c2855db
Compare
rgrunber
reviewed
Apr 7, 2022
AlexXuChen
force-pushed
the
check-binary-permission-error
branch
2 times, most recently
from
0d6df6d to
9d1178c
Compare
Signed-off-by: Alexander Chen <[email protected]>
AlexXuChen
force-pushed
the
check-binary-permission-error
branch
from
9d1178c to
07537d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added permission check and window error message for LemMinx binary
Signed-off-by: Alexander Chen [email protected]