Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate need for downloading just-released binary checksums. #650

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

rgrunber
Copy link
Member

@rgrunber rgrunber commented Feb 3, 2022

  • When the build process finishes building binaries, and generating the
    checksums, we should stash these to avoid having to download once
    deployed
  • Also use ovsx<0.3.0 to ensure we build with Node v12

Signed-off-by: Roland Grunberg [email protected]

- When the build process finishes building binaries, and generating the
  checksums, we should stash these to avoid having to download once
  deployed
- Also use ovsx<0.3.0 to ensure we build with Node v12

Signed-off-by: Roland Grunberg <[email protected]>
@rgrunber rgrunber requested a review from fbricon February 3, 2022 22:03
Copy link
Contributor

@AlexXuChen AlexXuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgrunber rgrunber merged commit 661345e into redhat-developer:master Feb 4, 2022
@rgrunber rgrunber deleted the fix-build branch February 4, 2022 17:23
@rgrunber rgrunber added this to the 0.18.4 milestone Feb 4, 2022
@angelozerr angelozerr added enhancement New feature or request build and removed enhancement New feature or request labels Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants