Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download external resources preference #640

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Download external resources preference #640

merged 1 commit into from
Jan 28, 2022

Conversation

angelozerr
Copy link
Contributor

Download external resources preference

Signed-off-by: azerr [email protected]

@angelozerr angelozerr mentioned this pull request Jan 26, 2022
Merged
@angelozerr angelozerr force-pushed the downloadExternalRessource branch 2 times, most recently from d0ece63 to 25eb806 Compare January 27, 2022 05:44
@angelozerr angelozerr marked this pull request as ready for review January 27, 2022 06:10
@angelozerr angelozerr force-pushed the downloadExternalRessource branch from 25eb806 to 243ab71 Compare January 27, 2022 06:23
fbricon
fbricon reviewed Jan 27, 2022
View reviewed changes
src/settings/settings.ts Outdated Show resolved Hide resolved
@angelozerr angelozerr force-pushed the downloadExternalRessource branch from 243ab71 to c878132 Compare January 27, 2022 08:58
rgrunber
rgrunber reviewed Jan 27, 2022
View reviewed changes
src/settings/settings.ts Outdated Show resolved Hide resolved
@angelozerr angelozerr force-pushed the downloadExternalRessource branch from c878132 to d8e5ab3 Compare January 27, 2022 21:48
@rgrunber
Copy link
Member

rgrunber commented Jan 27, 2022 •
edited
Loading

One small case I noticed :

  1. Open a workspace and do not grant trust. Remote schemas won't download, as expected.
  2. Now grant workspace trust
  3. The schema still won't download, and will show a message for the download being disabled
  4. If you reload the window it should work as expected again

This is because workspace trust is checked once at activation, but we're not using the onDidGrantWorkspaceTrust event. See https://github.com/redhat-developer/vscode-java/blob/master/src/extension.ts#L447-L449 for how to do it. I guess this may also be an issue with resolving entities ?

Update : Also, I think the setting here should be added to restrictedConfigurations in package.json to ensure no workspace is able to override it with its own setting.

rgrunber
rgrunber approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with merging. @AlexXuChen , can address the issue I mentioned in a separate PR.

@rgrunber rgrunber added this to the 0.18.3 milestone Jan 28, 2022
@AlexXuChen AlexXuChen mentioned this pull request Jan 28, 2022
Merged
@fbricon fbricon merged commit ed8e6bb into redhat-developer:master Jan 28, 2022
@fbricon
Copy link
Collaborator

fbricon commented Jan 28, 2022

thanks @angelozerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbricon fbricon fbricon left review comments

@rgrunber rgrunber rgrunber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.18.3
Development

Successfully merging this pull request may close these issues.
3 participants
@angelozerr @rgrunber @fbricon