-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added BindingWithGrammar.md to document vscode-xml grammar binding #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 29, 2021
datho7561
requested changes
Jul 29, 2021
datho7561
requested changes
Jul 29, 2021
AlexXuChen
force-pushed
the
issue567
branch
2 times, most recently
from
July 29, 2021 20:24
e4cc8e5
to
a0414a5
Compare
AlexXuChen
commented
Jul 29, 2021
datho7561
requested changes
Jul 29, 2021
datho7561
requested changes
Jul 29, 2021
datho7561
approved these changes
Jul 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
angelozerr
reviewed
Jul 30, 2021
angelozerr
reviewed
Jul 30, 2021
angelozerr
reviewed
Jul 30, 2021
angelozerr
reviewed
Jul 30, 2021
angelozerr
reviewed
Jul 30, 2021
angelozerr
reviewed
Jul 30, 2021
Great documentation @AlexXuChen, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added BindingWithGrammar.md to document vscode-xml grammar binding using existing grammar with binding wizard and how to generate a new grammar file.
Closes #567
Signed-off-by: Alexander Chen [email protected]