Made resolveExternalEntities depend of workspace trust #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
reviewed
Jul 7, 2021
datho7561
requested changes
Jul 7, 2021
datho7561
requested changes
Jul 8, 2021
datho7561
approved these changes
Jul 8, 2021
|
The change is good, but I think this really needs to be documented, at least on the setting itself. |
|
Documentation: #546 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the resolveExternalEntities setting to depend on workspace trust, where it uses user settings in trusted workspaces, and is false in untrusted workspaces.
Closes #537
Signed-off-by: Alexander Chen [email protected]