Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Features.md page to documentation #483

Merged
merged 1 commit into from
May 26, 2021

Conversation

AlexXuChen
Copy link
Contributor

Added a feature page to README and a few feature demos and descriptions mentioned by Angelo for vscode-xml documentation, including tag auto close, jump and rename.

Reference: #475

Signed-off-by: Alexander Chen [email protected]

docs/Features.md Outdated Show resolved Hide resolved
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think this is good. I would just do one showing DTD generation and then I think we can merge.

docs/Features.md Outdated

Using `/` in an opening tag will auto close the tag.

![Auto Close Tag 1](images/Features/AutoCloseTag1.gif)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably rename the file and reference to AutoCloseTagSlash.gif The other one can be AutoCloseTagEnd.gif. It just makes it easier to know which ones which without even looking at the document.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you confirm what the DTD generation feature is?

Copy link
Member

@rgrunber rgrunber May 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

UPDATE : Better yet, to go with the simple examples, I'd just make a document with <foo><bar></bar></foo> ..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angelozerr
Copy link
Contributor

angelozerr commented May 26, 2021

Please note https://github.com/redhat-developer/vscode-xml#featuresdeclares features too.

I think it should be nice to set a link for:

  • Auto-close tags
  • Renaming support

docs/Features.md Outdated Show resolved Hide resolved
docs/Features.md Outdated Show resolved Hide resolved
@angelozerr
Copy link
Contributor

angelozerr commented May 26, 2021

@AlexXuChen please squash your all commits in one commit.


## Rename Tag

To rename a single tag and it's corresponding opening/closing, highlight the tag and press `F2` or use the dropdown to select `Rename Symbol`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 'its' , but we can fix this prior to releasing, and on the next set of additions here.

@rgrunber rgrunber merged commit 23b7678 into redhat-developer:master May 26, 2021
@angelozerr
Copy link
Contributor

Thanks @AlexXuChen !

Please review my little PR with links #485

@rgrunber rgrunber added this to the 0.17.0 milestone Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants