-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Features.md page to documentation #483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think this is good. I would just do one showing DTD generation and then I think we can merge.
docs/Features.md
Outdated
|
||
Using `/` in an opening tag will auto close the tag. | ||
|
||
![Auto Close Tag 1](images/Features/AutoCloseTag1.gif) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably rename the file and reference to AutoCloseTagSlash.gif The other one can be AutoCloseTagEnd.gif. It just makes it easier to know which ones which without even looking at the document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you confirm what the DTD generation feature is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
- Copy something like https://git.eclipse.org/c/orbit/orbit-recipes.git/plain/apache/ant/org.apache.ant_1.10.10/src/eclipse/ip_log.xml locally, and open it in a folder.
- On the root element you should see a faint (informational) marker. If you select it, or activate quick fix you should see a few actions. I would demo "Generate ... and bind with xml-model"
UPDATE : Better yet, to go with the simple examples, I'd just make a document with <foo><bar></bar></foo> ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note https://github.com/redhat-developer/vscode-xml#featuresdeclares features too. I think it should be nice to set a link for:
|
@AlexXuChen please squash your all commits in one commit. |
|
||
## Rename Tag | ||
|
||
To rename a single tag and it's corresponding opening/closing, highlight the tag and press `F2` or use the dropdown to select `Rename Symbol`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be 'its' , but we can fix this prior to releasing, and on the next set of additions here.
Thanks @AlexXuChen ! Please review my little PR with links #485 |
Added a feature page to README and a few feature demos and descriptions mentioned by Angelo for vscode-xml documentation, including tag auto close, jump and rename.
Reference: #475
Signed-off-by: Alexander Chen [email protected]