-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new formatting setting xml.format.splitAttributesIndentSize
#386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please see the server side changes: eclipse-lemminx/lemminx#952 |
fbricon
reviewed
Dec 22, 2020
angelozerr
reviewed
Dec 23, 2020
datho7561
force-pushed
the
only-one-tab
branch
from
December 23, 2020 14:50
63101e9
to
ca04f28
Compare
datho7561
changed the title
Add new formatting setting
Add new formatting setting Dec 23, 2020
xml.format.numberOfIndentsForSplitAttributes
xml.format.splitAttributesIndentSize
|
datho7561
force-pushed
the
only-one-tab
branch
from
December 23, 2020 14:54
ca04f28
to
9887843
Compare
angelozerr
reviewed
Dec 23, 2020
@datho7561 the new |
datho7561
force-pushed
the
only-one-tab
branch
from
December 23, 2020 15:26
9887843
to
f646d17
Compare
datho7561
commented
Dec 23, 2020
angelozerr
reviewed
Dec 23, 2020
datho7561
force-pushed
the
only-one-tab
branch
from
December 23, 2020 15:29
f646d17
to
f3c81e2
Compare
Add a new setting which controls the level of indentation of attributes with respect to their parent element when `xml.format.splitAttributes` is set to `true`. Based off of a comment by Cong Wang (@I322871) on the vscode-xml Gitter Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
only-one-tab
branch
from
December 23, 2020 15:30
f3c81e2
to
caad279
Compare
angelozerr
approved these changes
Dec 23, 2020
Thanks @datho7561 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new setting which controls the level of indentation of attributes
with respect to their parent element when
xml.format.splitAttributes
is set to
true
.Based off of a comment by Cong Wang (@I322871) on the vscode-xml Gitter
Signed-off-by: David Thompson [email protected]