-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xml.extension.jars
to add LemMinX extension jars
#336
Merged
angelozerr
merged 1 commit into
redhat-developer:master
from
datho7561:251-setting-for-jar-extensions
Oct 9, 2020
Merged
xml.extension.jars
to add LemMinX extension jars
#336
angelozerr
merged 1 commit into
redhat-developer:master
from
datho7561:251-setting-for-jar-extensions
Oct 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I manually tested this with the Liquidbase extension |
|
datho7561
force-pushed
the
251-setting-for-jar-extensions
branch
from
October 6, 2020 18:43
690d469
to
9de9b27
Compare
angelozerr
reviewed
Oct 6, 2020
angelozerr
reviewed
Oct 7, 2020
angelozerr
reviewed
Oct 7, 2020
angelozerr
reviewed
Oct 7, 2020
@datho7561 I think we should remove replace content of https://github.com/redhat-developer/vscode-xml#custom-xml-extensions with a link to the Extensions.md (not from the wiki but from the docs folder). |
datho7561
force-pushed
the
251-setting-for-jar-extensions
branch
2 times, most recently
from
October 7, 2020 15:38
c41082e
to
4591b01
Compare
datho7561
force-pushed
the
251-setting-for-jar-extensions
branch
3 times, most recently
from
October 9, 2020 14:08
b52297a
to
c9c9de4
Compare
angelozerr
reviewed
Oct 9, 2020
angelozerr
reviewed
Oct 9, 2020
Adds a new setting `xml.extension.jars`, where you can list jars to contribute to the LemMinX classpath. You can use this feature to test LemMinX extensions in VSCode. Closes redhat-developer#251 Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
251-setting-for-jar-extensions
branch
from
October 9, 2020 14:16
c9c9de4
to
3e6c085
Compare
angelozerr
approved these changes
Oct 9, 2020
Thanks @datho7561 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new setting
xml.extension.jars
, where you can list jars to contribute to the LemMinX classpath. You can use this feature to test LemMinX extensions in VSCode.Closes #251
Signed-off-by: David Thompson [email protected]