Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml.extension.jars to add LemMinX extension jars #336

Merged

Conversation

datho7561
Copy link
Contributor

Adds a new setting xml.extension.jars, where you can list jars to contribute to the LemMinX classpath. You can use this feature to test LemMinX extensions in VSCode.

Closes #251

Signed-off-by: David Thompson [email protected]

@datho7561
Copy link
Contributor Author

I manually tested this with the Liquidbase extension

@datho7561
Copy link
Contributor Author

datho7561 commented Oct 6, 2020

Need to update the internal docs with a better description updated

@datho7561 datho7561 force-pushed the 251-setting-for-jar-extensions branch from 690d469 to 9de9b27 Compare October 6, 2020 18:43
package.json Outdated Show resolved Hide resolved
docs/Preferences.md Outdated Show resolved Hide resolved
docs/Preferences.md Outdated Show resolved Hide resolved
docs/Preferences.md Outdated Show resolved Hide resolved
@angelozerr
Copy link
Contributor

@datho7561 I think we should remove replace content of https://github.com/redhat-developer/vscode-xml#custom-xml-extensions with a link to the Extensions.md (not from the wiki but from the docs folder).

@datho7561 datho7561 force-pushed the 251-setting-for-jar-extensions branch 2 times, most recently from c41082e to 4591b01 Compare October 7, 2020 15:38
@datho7561 datho7561 force-pushed the 251-setting-for-jar-extensions branch 3 times, most recently from b52297a to c9c9de4 Compare October 9, 2020 14:08
docs/Extensions.md Outdated Show resolved Hide resolved
docs/Extensions.md Outdated Show resolved Hide resolved
Adds a new setting `xml.extension.jars`, where you can list jars to contribute
to the LemMinX classpath. You can use this feature to test LemMinX
extensions in VSCode.

Closes redhat-developer#251

Signed-off-by: David Thompson <[email protected]>
@datho7561 datho7561 force-pushed the 251-setting-for-jar-extensions branch from c9c9de4 to 3e6c085 Compare October 9, 2020 14:16
@angelozerr angelozerr merged commit 4f002c9 into redhat-developer:master Oct 9, 2020
@angelozerr
Copy link
Contributor

Thanks @datho7561 !

@datho7561 datho7561 deleted the 251-setting-for-jar-extensions branch January 18, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add LemMinx extensions via vscode user settings
2 participants