Add variables for `xml.fileAssociations` #334

datho7561 · 2020-10-02T20:20:01Z

Adds three variables that can be used in xml.fileAssociations:

${workspaceFolder}
${fileDirname}
${fileBasenameNoExtension}

These variables can be used for both the pattern and the systemId.

Closes #307

Signed-off-by: David Thompson [email protected]

datho7561 · 2020-10-02T20:25:42Z

This change is client only: the variables only in vscode-xml, not any of the other clients that LemMinX supports.

Still need to:

Clean up the code
~~Add documentation in wiki~~ we are moving the wiki contents to the docs folder
Add documentation to internal documents
Detect if there is no change in settings on tab change (i.e. there is no fileDirname or fileBasenameNoExtension references in the settings), and don't rebroadcast settings

fbricon · 2020-10-13T16:44:33Z

please rebase against master

datho7561 · 2020-10-13T17:16:37Z

~~I messed up the rebase, one second...~~ Okay should be fixed

src/extension.ts

src/variableReference.ts

src/extension.ts

src/variableSubstitution.ts

Adds three variables that can be used in `xml.fileAssociations`: * ${workspaceFolder} * ${fileDirname} * ${fileBasenameNoExtension} These variables can be used for both the `pattern` and the `systemId`. Closes redhat-developer#307 Signed-off-by: David Thompson <[email protected]>

angelozerr

Great job @datho7561 !

datho7561 force-pushed the 307-variables-in-file-associations branch 3 times, most recently from 5cd3a2f to 7e10726 Compare October 5, 2020 15:01

datho7561 marked this pull request as ready for review October 5, 2020 15:09

datho7561 force-pushed the 307-variables-in-file-associations branch 2 times, most recently from 20eedb1 to cef9c32 Compare October 7, 2020 17:41

datho7561 requested a review from angelozerr October 7, 2020 17:42

datho7561 force-pushed the 307-variables-in-file-associations branch from cef9c32 to 517a905 Compare October 13, 2020 17:10

datho7561 force-pushed the 307-variables-in-file-associations branch 2 times, most recently from 517a905 to 9d63ce5 Compare October 13, 2020 17:20

angelozerr reviewed Oct 27, 2020

View reviewed changes