Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows editing of start/end tag simultaneously #207

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Allows editing of start/end tag simultaneously #207

merged 1 commit into from
Dec 13, 2019

Conversation

xorye
Copy link

@xorye xorye commented Dec 13, 2019

Fixes #130, branched off the branch from #204

This PR updates the cursor(s) when toggling the config

Signed-off-by: Nikolas Komonen [email protected]

@fbricon
Copy link
Collaborator

fbricon commented Dec 13, 2019

when no folder/workspace is opened, if you edit an xml file, the toggle command doesn't work
If a pref key exists in the workspace, then toggling mirror mode should change it, else, set the preference at the user level

@xorye
Copy link
Author

xorye commented Dec 13, 2019

@fbricon updated

@fbricon
Copy link
Collaborator

fbricon commented Dec 13, 2019

says "Toggled the xml.matchingTagEditing preference in the Workspace settings.", even though there's no workspace

Under the preference xml.autoSelectingMatchingTags

Fixes #130

Signed-off-by: Nikolas Komonen <[email protected]>
@fbricon fbricon merged commit 9f32fc1 into redhat-developer:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto Rename Tag
3 participants