Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude ParentProcessWatcher by default #116

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Exclude ParentProcessWatcher by default #116

merged 1 commit into from
Mar 20, 2019

Conversation

ralish
Copy link
Contributor

@ralish ralish commented Mar 19, 2019

Disables the parent process watcher for lsp4xml by default.

For additional context on this change see: eclipse-lemminx/lemminx#328.

The support in lsp4xml is introduced in: eclipse-lemminx/lemminx#330.

This change is effectively mirroring that introduced to vscode-java by: redhat-developer/vscode-java#843.

@NikolasKomonen
Copy link
Contributor

I think we need to set defaults specific to the OS. I've tested on Fedora and the server does not end if the client does not close properly.

I've tested on Windows and it looks like the PPW isn't necessary there.

MacOS hasn't been tested yet.

@fbricon would you be able to test MacOS when you have time?

@fbricon
Copy link
Collaborator

fbricon commented Mar 19, 2019

@NikolasKomonen how did you check on Fedora. @snjeza said should couldn't get zombie processes on linux. It was fine on Mac, as far as I tested

@fbricon
Copy link
Collaborator

fbricon commented Mar 19, 2019

@ralish can you please sign-off your commit? (git commit -s)

@NikolasKomonen
Copy link
Contributor

NikolasKomonen commented Mar 19, 2019

@fbricon

To recreate it I:

  1. I launched VSCode with the XML LS as either a VSIX or a Launched Extension (from development) with the flag -DwatchParentProcess=\"false\" added to vmargs.
  2. I ran jps to see if the ...uber.jar existed.
  3. I ran pkill code to kill all instances of VSCode
  4. I waited a bit then ran jps, vscode-java disappeared but vscode-xml was still there.
    I already had vscode-java installed, so that is why it showed in jps. But they use the same PPW mechanic so I know it works when enabled.

@fbricon
Copy link
Collaborator

fbricon commented Mar 20, 2019

@ralish
Copy link
Contributor Author

ralish commented Mar 20, 2019

@fbricon: Amended commit per vscode-java implementation and signed as requested.

@fbricon fbricon added the enhancement New feature or request label Mar 20, 2019
@fbricon fbricon added this to the 0.5.0 milestone Mar 20, 2019
Copy link
Collaborator

@fbricon fbricon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ralish!

@fbricon fbricon merged commit 7767fcb into redhat-developer:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants