-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warnings in extension development #98
Comments
@Eskibear do you think you could provide a PR? |
It's a one-line change for the first one. For the second one, the statement is written in such way because
|
Use method described by Eskibear to access [xml] autoclosing settings. Rescope `xml.completion.autoCloseTags` as a resource setting. Closes redhat-developer#98 Signed-off-by: David Thompson <[email protected]>
Use method described by Eskibear to access [xml] autoclosing settings. Do not provide a document when getting the settings, since LemMinX doesn't support multi-root projects right now. Closes redhat-developer#98 Signed-off-by: David Thompson <[email protected]>
@Eskibear I worked on a quick PR to address these warnings. I used the method you described to fix the first warning to address both the warnings, since LemMinX doesn't support multi-root workspaces yet. Does this solution make sense? |
@datho7561 commented, you shall refer to vscode's API spec. |
@Eskibear, Thanks for your help! |
Use method described by Eskibear to access [xml] autoclosing settings. Do not provide a document when accessing vscode-xml settings, since LemMinX doesn't support multi-root projects right now. Closes redhat-developer#98 Signed-off-by: David Thompson <[email protected]>
Not a blocking issue. Just some annoying warning messages in debug console if I have xml extension installed.
The first one:
vscode-xml/src/extension.ts
Line 128 in 32b586c
let configXML = workspace.getConfiguration(undefined, null)
,ConfigXML.get("[xml]")
should work.The second one:
vscode-xml/src/extension.ts
Line 86 in 32b586c
vscode-xml/src/tagClosing.ts
Line 32 in 407cd65
vscode-xml/package.json
Lines 152 to 156 in 32b586c
The text was updated successfully, but these errors were encountered: