Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Surround" Commands are not shown in the Command Palette #923

Closed
enxio opened this issue Jul 26, 2023 · 5 comments · Fixed by #924
Closed

"Surround" Commands are not shown in the Command Palette #923

enxio opened this issue Jul 26, 2023 · 5 comments · Fixed by #924
Assignees
@angelozerr
Labels
bug Something isn't working
Milestone
0.27.0

Comments

@enxio
Copy link

enxio commented Jul 26, 2023

The commands xml.refactor.surround.with.* are not shown in the command palette. The other ones are, e.g. xml.validation.current.file or xml.restart.language.server are shown and can be invoked.

I can assign keys to these "surround" commands just fine, and then they work as expected, I just cannot invoke them via the palette.
@enxio
Copy link
Author

enxio commented Jul 26, 2023

I am using the preview: v0.26.2023072504

@angelozerr angelozerr self-assigned this Jul 26, 2023
@angelozerr angelozerr added the bug Something isn't working label Jul 26, 2023
angelozerr added a commit to angelozerr/vscode-xml that referenced this issue Jul 26, 2023
@angelozerr
"Surround" Commands are not shown in the Command Palette
fa08922 
Fixes redhat-developer#923

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr mentioned this issue Jul 26, 2023
Merged
@angelozerr
Copy link
Contributor

angelozerr commented Jul 26, 2023 •
edited
Loading

Indeed we introduced a bug, I created a PR to fix it #924

Thanks @enxio for having reported the issue!

@angelozerr angelozerr added this to the 0.26.2 milestone Jul 26, 2023
@angelozerr angelozerr moved this to 👀 In review in IDE Cloudaptors Jul 26, 2023
datho7561 pushed a commit that referenced this issue Jul 26, 2023
@angelozerr @datho7561
"Surround" Commands are not shown in the Command Palette
e5baa16 
Fixes #923

Signed-off-by: azerr <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors Jul 26, 2023
@angelozerr
Copy link
Contributor

@enxio your issue should be fixed, you have to wait tomorrow to install the prerelease. Please try it and give us feedback if it is working for you. Thanks.

@enxio
Copy link
Author

enxio commented Jul 27, 2023

Hi @angelozerr, I just got the update and it now works as expected. Thanks a lot for the fix and the fast response!

@angelozerr
Copy link
Contributor

Great thanks for your feedbavk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working
Projects
IDE Cloudaptors
Archived in project
Milestone
0.27.0
Development

Successfully merging a pull request may close this issue.

"Surround" Commands are not shown in the Command Palette angelozerr/vscode-xml
2 participants
@angelozerr @enxio