no svg validation if jock.svg is also installed

[BuZZ-dEE]

No svg validation if jock.svg is also installed. If for example the svg has a group and you remove the end tag </g>, then you get no error, so the validation does not work.

[BuZZ-dEE]

Thx for your fast fix. Release it 🚀

[angelozerr]

@BuZZ-dEE once build we be done you will able to install vscode-xml prerelease to enjoy with this fix

[angelozerr]

@BuZZ-dEE you can install pre-release to enjoy with this fix. Please give me feedback.

You should set xml.validation.resolveExternalEntities to true, see #810

[BuZZ-dEE]

Hi @angelozerr I will try it, but what do I need from: releases/tag/latest ?

[angelozerr]

Try to install vscode-xml as you did, and click on Switch To Pre Release version

[BuZZ-dEE]

g: Group Element ..................................

Source: [svg11.dtd](vscode-file://vscode-app/usr/lib/code/out/vs/code/electron-sandbox/workbench/workbench.html)

The SVG element is a container used to group other SVG elements.

[MDN Reference](vscode-file://vscode-app/usr/lib/code/out/vs/code/electron-sandbox/workbench/workbench.html)

The element type "g" must be terminated by the matching end-tag "</g>".xml(ETagRequired)
test.svg(54, 9): Closing tag expected here

It works now. (Content from hovering over the g element above)

[angelozerr]

Thanks for your feedback.

The problem now is with completion. You will see 2 duplicate completion item for the same element which comes from jock.svg and vscode-xml.

I think vscode-xml could support the same feature than jock.svg like better hover documentation and color for rgb attribute.

I will see if jock.svg could be interested to delegate thise features to vscode-xml

[BuZZ-dEE]

@angelozerr I have created lishu/vscode-svg2#129 just to make vscode-svg2 / jock.svg aware if the issue.

[lishu]

@BuZZ-dEE
I installed the vscode-xml plugin and found no duplicate completions, whether some specific configuration or version has changed?

[angelozerr]

@lishu have you svg validation which is working?

Could you share your svg file please. It requires the svg namespace if I remember

[lishu]

Maybe it's not working properly.

[angelozerr]

Could you share please your svg file

[angelozerr]

I tested it and you can see duplicate completion items:

Here my svg file:

<?xml version="1.0" standalone="no"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" 
  "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
<svg width="5cm" height="4cm" version="1.1"
     xmlns="http://www.w3.org/2000/svg">
     <a xlink:href=""></a>
  <desc>Four separate rectangles
  </desc>
    <a
    <rect x="0.5cm" y="0.5cm" width="2cm" height="1cm"/>
    <rect x="0.5cm" y="2cm" width="1cm" height="1.5cm"/>
    <rect x="3cm" y="0.5cm" width="1.5cm" height="2cm"/>
    <rect x="3.5cm" y="3cm" width="1cm" height="0.5cm"/>

  <!-- Show outline of canvas using 'rect' element -->
  <rect x=".01cm" y=".01cm" width="4.98cm" height="3.98cm"
        fill="none" stroke="blue" stroke-width=".02cm" />

</svg>

You can notice you need to declare DOCTYPE.

Is the validation working for you?

[angelozerr]

I noticed in the log the same error than you, but is is working for me. We need to invesitgate this error log.

[angelozerr]

I noticec that the first completion item a (coming from vscode-xml) generates:

<a xlink:href=""></a>

which is valid according to the DTD, although your extension generates:

<a href="#url"></a>

which seems not be valid. Is it allowed?

[lishu]

Yes, my svg doesn't use DOCTYPE

DOCTYPE - MDN does not recommend using DOCTYPE

xlink:href - Deprecated XLink URL reference attributes

[angelozerr]

Yes, my svg doesn't use DOCTYPE

LemMinx doesn't provide a specific SVG support, so you need to declare the DOCTYPE with the proper DTD. But it is possible to write a little Java LemMinx extension which does that. But I think you will not be interested to provide that.

My another idea is to gives the capability to do that with package.json in your extension point (no dependency to vscode-xml), but before developping that, we need some user requirements.

[lishu]

There are many conflicts between the standards under HTML and the XML standard, so it is indeed a problem that is not easy to handle 🤣