Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'No definition found' when using 'Go to Definition' for types defined in imported XSD #632

Closed
jawn opened this issue Jan 3, 2022 · 4 comments · Fixed by eclipse-lemminx/lemminx#1146
Closed

'No definition found' when using 'Go to Definition' for types defined in imported XSD #632

jawn opened this issue Jan 3, 2022 · 4 comments · Fixed by eclipse-lemminx/lemminx#1146
Labels
bug Something isn't working
Milestone
0.18.3

Comments

@jawn
Copy link

jawn commented Jan 3, 2022 •
edited
Loading

Summary

Go to definition works to navigate to a complex type defined in the same XSD.
However, this fails when the complex type is defined in an imported file, giving error message 'No definition found for ...'

Steps to reproduce

  1. Unzip repro files to local folder, that is a trusted workspace
  2. Open Parent.xsd in VS Code
  3. Apply go to definition on line 11, 'SomeGenericType'.

Actual result:

image

Expected result

The type definition is selected in the Child.xsd file.

Repro files

repro.zip containing Parent.xsd and Child.xsd

VS Code version info

Version: 1.63.2 (system setup)
Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3
Date: 2021-12-15T09:40:02.816Z (2 wks ago)
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19044

Extension version info

XML: v0.18.2
Red Hat Commons: v0.0.6
angelozerr added a commit to angelozerr/lemminx that referenced this issue Jan 4, 2022
@angelozerr
'No definition found' when using 'Go to Definition' for types defined in
6cb5908 
imported XSD

Fixes redhat-developer/vscode-xml#632

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr mentioned this issue Jan 4, 2022
Merged
@angelozerr
Copy link
Contributor

Thanks @jawn for your detailed issue. eclipse-lemminx/lemminx#1146 should fix your issue

@fbricon fbricon added the bug Something isn't working label Jan 4, 2022
@fbricon fbricon added this to the 0.18.3 milestone Jan 4, 2022
fbricon pushed a commit to eclipse-lemminx/lemminx that referenced this issue Jan 4, 2022
@angelozerr @fbricon
'No definition found' when using 'Go to Definition' for types defined in
29530bc 
imported XSD

Fixes redhat-developer/vscode-xml#632

Signed-off-by: azerr <[email protected]>
@angelozerr
Copy link
Contributor

@jawn you can install last vesrion of vscode-xml by downloading vsix https://download.jboss.org/jbosstools/vscode-xml/staging/?C=M;O=D and give us feedback. Thanks

@jawn
Copy link
Author

jawn commented Jan 5, 2022

@jawn you can install last vesrion of vscode-xml by downloading vsix https://download.jboss.org/jbosstools/vscode-xml/staging/?C=M;O=D and give us feedback. Thanks

Verified as fixed using version vscode-xml-0.18.3-472.vsix

@angelozerr
Copy link
Contributor

Great thanks @jawn !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.18.3
3 participants
@fbricon @jawn @angelozerr