Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format comments which have no end comments should not generate end comments #347

Closed
clembo590 opened this issue Oct 24, 2020 · 1 comment · Fixed by eclipse-lemminx/lemminx#920
Assignees
Labels
bug Something isn't working formatting
Milestone

Comments

@clembo590
Copy link

vscode Version: 1.50.1
on macosx version 10.14.6

There is an error when performing "format modified lines": please see following gif to get the scenario.
vscode issue gif

@angelozerr
Copy link
Contributor

angelozerr commented Oct 26, 2020

Thanks for reporting this issue.

This problem is easy to reproduce.

Given this XML:

<foo>
	<!-- 
</foo>

After formatting, it generates the end comment:

<foo>
	<!-- 
</foo>-->

Although it should not generate the -->.

There is the same problem with CDATA:

<foo>
	<![CDATA[ 
</foo>

This problem should be fixed with the PR eclipse-lemminx/lemminx#920

@angelozerr angelozerr added this to the 0.14.0 milestone Oct 26, 2020
@angelozerr angelozerr self-assigned this Oct 26, 2020
@angelozerr angelozerr added bug Something isn't working formatting labels Oct 26, 2020
@angelozerr angelozerr changed the title issue when formatting "modified lines" Format comments which have no end comments should not generate end comments Oct 26, 2020
@angelozerr angelozerr reopened this Oct 26, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 26, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 26, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue Oct 26, 2020
datho7561 pushed a commit to eclipse-lemminx/lemminx that referenced this issue Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working formatting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants