Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextMate grammar for *.dtd files #313

Closed
datho7561 opened this issue Aug 26, 2020 · 4 comments · Fixed by #713
Closed

TextMate grammar for *.dtd files #313

datho7561 opened this issue Aug 26, 2020 · 4 comments · Fixed by #713
Labels
enhancement New feature or request textmate
Milestone
0.21.0

Comments

@datho7561
Copy link
Contributor

I think it could be helpful to provide a TextMate grammar for *.dtd files. Syntax highlighting would make it a bit easier to read and edit these files.

It looks like nothing is being done to implement it upstream in VSCode: VSCode related issue. VSCode just reuses the Atom TextMate grammar for XML/DTD: Atom issue. The Atom TextMate grammar was extracted from the TextMate XML plugin. This grammar doesn't include syntax highlighting for DTD.
@angelozerr
Copy link
Contributor

Indeed it should be really nice to improve syntax coloration for DTD and perhaps contribute to vscode?

@datho7561 datho7561 added the enhancement New feature or request label Aug 27, 2020
@datho7561
Copy link
Contributor Author

Yes. Now that I think about it, this would make more sense upstream in vscode.

@datho7561
Copy link
Contributor Author

FYI https://github.com/chrisbra/vim-xml-runtime/blob/master/syntax/dtd.vim

@angelozerr
Copy link
Contributor

angelozerr commented May 19, 2022 •
edited
Loading

After quick search I have found https://github.com/sebastienscout/atom-dtd-language/blob/master/grammars/dtd.cson but it is very basic.

I think we could start with that and improve it step by step. When we will have an advanced textmate for DTD we could try to contribute to vscode.

angelozerr added a commit to angelozerr/vscode-xml that referenced this issue May 19, 2022
@angelozerr
TextMate grammar for *.dtd files
4f7da08 
Fixes redhat-developer#313

Signed-off-by: azerr <[email protected]>
angelozerr added a commit to angelozerr/vscode-xml that referenced this issue May 19, 2022
@angelozerr
TextMate grammar for *.dtd files
9371e5f 
Fixes redhat-developer#313

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr mentioned this issue May 19, 2022
Merged
angelozerr added a commit to angelozerr/vscode-xml that referenced this issue May 28, 2022
@angelozerr
TextMate grammar for *.dtd files
33860eb 
Fixes redhat-developer#313

Signed-off-by: azerr <[email protected]>
angelozerr added a commit to angelozerr/vscode-xml that referenced this issue May 30, 2022
@angelozerr
TextMate grammar for *.dtd files
5f9bd2a 
Fixes redhat-developer#313

Signed-off-by: azerr <[email protected]>
angelozerr added a commit that referenced this issue May 31, 2022
@angelozerr
TextMate grammar for *.dtd files
ca4da0d 
Fixes #313

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr added this to the 0.21.0 milestone May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request textmate
Projects
None yet
Milestone
0.21.0
Development

Successfully merging a pull request may close this issue.

TextMate grammar for *.dtd files angelozerr/vscode-xml
2 participants
@angelozerr @datho7561