Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.27.0] bad CPU type in executable on OSX (Intel) #1001

Closed
alycklama opened this issue May 30, 2024 · 7 comments · Fixed by #1002
Closed

[0.27.0] bad CPU type in executable on OSX (Intel) #1001

alycklama opened this issue May 30, 2024 · 7 comments · Fixed by #1002
Milestone
0.27.1

Comments

@alycklama
Copy link

I'm trying to run LemMinX 0.27.0 on Sonoma 14.4.1 (2,4 GHz 8-Core Intel Core i9), but I get the following error:

bad CPU type in executable

Version 0.26.1 works as expected.
@alycklama alycklama mentioned this issue May 30, 2024
Closed
@angelozerr
Copy link
Contributor

@rgrunber @datho7561 have you some idea?

@rgrunber
Copy link
Member

rgrunber commented May 30, 2024 •
edited
Loading

I think I see the problem :

$ file ./new/extension/server/lemminx-osx-x86_64
./new/extension/server/lemminx-osx-x86_64: Mach-O 64-bit arm64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|PIE>

It wasn't "arm64" in 0.26.1 . That looks completely wrong. We should get to the bottom of it and produce a bug fix release.

Update: I don't yet see how, but the entire job to build the x64 bit binary server ran on an aarch64 runner 😐

Update 2: Maybe at https://github.com/redhat-developer/vscode-xml/pull/964/files#diff-b80496605edd832dcf2d81e352ad212e9ea5251b616374f061fdf03077050918R31-R35 macos-latest still was using 12 and we explicitly took 14 for aarch64. maybe that 'latest' silently changed, and we never noticed.

@alycklama
Copy link
Author

Thanks for the lightning fast replies, and awesome to see you already found something! I know it's far too early, but If I can test anything, just let me know 👍

@fbricon
Copy link
Collaborator

fbricon commented May 30, 2024

@rgrunber according to https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories, macos-latest runs on Mac M1s

@fbricon fbricon mentioned this issue May 30, 2024
Merged
@rgrunber rgrunber added this to the 0.27.1 milestone May 31, 2024
@rgrunber
Copy link
Member

rgrunber commented May 31, 2024 •
edited
Loading

@alycklama , this should be published as pre-release version 0.27.2024053103 . You can switch to pre-release from the VS Code extension view to try it. Let us know if it resolves the issue.

@alycklama
Copy link
Author

@rgrunber I can confirm the issue is gone with the pre-release. Thanks a lot for the quick fix everyone!

@angelozerr
Copy link
Contributor

@alycklama glad the issue has been fixed.

@rgrunber thanks so much!

radimsuckr added a commit to radimsuckr/mason-registry that referenced this issue Jun 1, 2024
@radimsuckr
fix(lemminx): split macOS targets
5833869 
In regards to mason-org#5922 and
redhat-developer/vscode-xml#1001, the same
issue also occurs on macOS with ARM64 chips. The error I get on ARM64 is:

The current machine does not support all of the following CPU features
that are required by the image: [CX8, CMOV, FXSR, MMX, SSE, SSE2, SSE3,
SSSE3, SSE4_1, SSE4_2, POPCNT, LZCNT, AVX, AVX2, BMI1, BMI2, FMA].
Please rebuild the executable with an appropriate setting of the -march
option.

Splitting the targets and installing the correct artifact fixes this. I
tested it locally. :)
@radimsuckr radimsuckr mentioned this issue Jun 1, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.27.1
Development

Successfully merging a pull request may close this issue.

Run osx-x86_64 builds on macos-13 runner fbricon/vscode-xml
4 participants
@fbricon @rgrunber @angelozerr @alycklama