Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple time pop-up of download and install kubectl information message #658

Merged
merged 4 commits into from
Nov 29, 2021

Conversation

sudhirverma
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #658 (f06bf88) into main (93def61) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
+ Coverage   67.86%   67.96%   +0.09%     
==========================================
  Files         114      114              
  Lines        6615     6623       +8     
  Branches     1164     1170       +6     
==========================================
+ Hits         4489     4501      +12     
+ Misses       2126     2122       -4     
Impacted Files Coverage Δ
src/tkn.ts 77.97% <100.00%> (+0.71%) ⬆️
src/util/list-tekton-resource.ts 100.00% <100.00%> (ø)
src/yaml-support/tkn-conditions-provider.ts 100.00% <100.00%> (ø)
src/yaml-support/tkn-tasks-provider.ts 98.03% <100.00%> (+0.08%) ⬆️
src/kubectl.ts 43.39% <0.00%> (+3.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93def61...f06bf88. Read the comment docs.

src/tools.json Outdated
@@ -57,5 +57,4 @@
}
}
}
}

}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new line there

Copy link
Collaborator

@evidolob evidolob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudhirverma sudhirverma merged commit 4501769 into redhat-developer:main Nov 29, 2021
@sudhirverma sudhirverma added this to the 1.0.0 milestone Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants