Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context menu and command to show logs #620

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Conversation

evidolob
Copy link
Collaborator

Resolve: #342

Demo:

Screen.Recording.2021-08-27.at.14.59.55.mov

@evidolob evidolob requested a review from sudhirverma August 27, 2021 12:34
@evidolob evidolob self-assigned this Aug 27, 2021
@evidolob evidolob requested a review from mohitsuman August 27, 2021 12:35
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021

Codecov Report

Merging #620 (41c6cba) into master (fb9c474) will decrease coverage by 0.04%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
- Coverage   68.38%   68.33%   -0.05%     
==========================================
  Files         114      114              
  Lines        6538     6550      +12     
  Branches     1151     1152       +1     
==========================================
+ Hits         4471     4476       +5     
- Misses       2067     2074       +7     
Impacted Files Coverage Δ
src/yaml-support/tkn-yaml.ts 92.92% <ø> (ø)
src/pipeline/preview.ts 19.53% <16.66%> (-0.15%) ⬇️
src/pipeline/pipeline-graph.ts 74.82% <63.63%> (-0.70%) ⬇️
src/tekton/taskrun.ts 81.37% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb9c474...41c6cba. Read the comment docs.

@evidolob evidolob requested a review from siamaksade September 14, 2021 14:32
Copy link
Contributor

@mohitsuman mohitsuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, we can explore other ways to showcase the Show Logs in the pipeline. Currently it hides in the larger view of the circle. And if there are multiple pipelines added, this can clutter the space.

Need to brainstorm more on the UX side of it.

@mohitsuman
Copy link
Contributor

@evidolob Let's proceed with the current UX and we can make iterations on it in future releases.

@evidolob evidolob merged commit d5866e9 into master Nov 15, 2021
@evidolob evidolob deleted the show-logs-from-diagram branch November 15, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display logs for taskrun from the pipelinerun diagram
3 participants