Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline wizard #338

Merged
merged 38 commits into from
Jul 31, 2020
Merged

Pipeline wizard #338

merged 38 commits into from
Jul 31, 2020

Conversation

sudhirverma
Copy link
Contributor

Fix: #310

@sudhirverma sudhirverma marked this pull request as draft July 9, 2020 10:17
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2020

Codecov Report

Merging #338 into master will decrease coverage by 1.65%.
The diff coverage is 30.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
- Coverage   74.58%   72.92%   -1.66%     
==========================================
  Files          49       52       +3     
  Lines        3427     3550     +123     
  Branches      616      642      +26     
==========================================
+ Hits         2556     2589      +33     
- Misses        871      961      +90     
Impacted Files Coverage Δ
src/tekton/pipelinecontent.ts 93.63% <ø> (ø)
src/pipeline/wizard.ts 20.28% <20.28%> (ø)
src/tkn.ts 66.24% <28.00%> (-1.00%) ⬇️
src/tekton/webviewstartpipeline.ts 28.57% <28.57%> (ø)
src/tekton/pipeline.ts 62.31% <37.14%> (-1.32%) ⬇️
src/tekton/startpipeline.ts 54.54% <54.54%> (ø)
src/tekton/tektonitem.ts 72.36% <66.66%> (-1.61%) ⬇️
src/extension.ts 90.40% <100.00%> (+0.07%) ⬆️
src/util/MultiStepInput.ts 23.72% <0.00%> (-2.51%) ⬇️
src/pipeline/preview.ts 20.35% <0.00%> (-0.70%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c28ac9...a1eac86. Read the comment docs.

@sudhirverma
Copy link
Contributor Author

Workspace UI @siamaksade and @evidolob
Screenshot 2020-07-15 at 1 34 44 AM

@sudhirverma
Copy link
Contributor Author

Parameters, Git and Image Resource UI

Screenshot 2020-07-15 at 1 35 44 AM

@sudhirverma sudhirverma marked this pull request as ready for review July 24, 2020 06:43
@evidolob
Copy link
Collaborator

@sudhirverma I got:
Screenshot 2020-07-24 at 09 53 19

Copy link
Collaborator

@evidolob evidolob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will continue review when I will able to test this

src/pipeline/wizard.ts Outdated Show resolved Hide resolved
@sudhirverma sudhirverma changed the title Pipeline wizard [WIP] Pipeline wizard Jul 26, 2020
@evidolob
Copy link
Collaborator

@sudhirverma I have empty wizard for this pipeline
Screenshot 2020-07-27 at 09 52 28

Copy link
Collaborator

@evidolob evidolob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to reorganize folder structure:

  • Rename element folder to widgets
  • move navigation.ts to widgets
  • move widget.ts to widgets

src/pipeline/wizard.ts Outdated Show resolved Hide resolved
src/webview/pipeline/app/common/item.ts Outdated Show resolved Hide resolved
src/webview/pipeline/app/common/item.ts Outdated Show resolved Hide resolved
src/webview/pipeline/app/common/item.ts Outdated Show resolved Hide resolved
src/webview/pipeline/app/common/resource.ts Outdated Show resolved Hide resolved
src/webview/pipeline/app/common/resource.ts Outdated Show resolved Hide resolved
src/webview/pipeline/app/common/resource.ts Outdated Show resolved Hide resolved
src/webview/pipeline/app/element/selectwidget.ts Outdated Show resolved Hide resolved
@sudhirverma sudhirverma changed the title Pipeline wizard Pipeline wizard [WIP] Jul 27, 2020
@sudhirverma
Copy link
Contributor Author

@sudhirverma I have empty wizard for this pipeline
Screenshot 2020-07-27 at 09 52 28

if YAML doesn't have params, git or image resources, and workspace I will directly start the pipeline. without showing the wizard.

@sudhirverma sudhirverma changed the title Pipeline wizard [WIP] Pipeline wizard Jul 28, 2020
@sudhirverma sudhirverma marked this pull request as draft July 28, 2020 10:27
@sudhirverma sudhirverma changed the title Pipeline wizard Pipeline wizard [WIP] Jul 28, 2020
@sudhirverma sudhirverma changed the title Pipeline wizard [WIP] Pipeline wizard Jul 28, 2020
@sudhirverma sudhirverma marked this pull request as ready for review July 28, 2020 16:51
@sudhirverma
Copy link
Contributor Author

@siamaksade and @evidolob

param, git and Image Resource Gif

resource

Workspace Gif

workspace

@evidolob
Copy link
Collaborator

@sudhirverma When wizard starts pipeline, it is open pipeline run diagram for previous pipelinerun:
Screenshot 2020-07-30 at 11 10 50

@sudhirverma
Copy link
Contributor Author

@sudhirverma When wizard starts pipeline, it is open pipeline run diagram for previous pipelinerun:
Screenshot 2020-07-30 at 11 10 50

okay, I will check this out.

src/tekton/pipeline.ts Outdated Show resolved Hide resolved
src/webview/pipeline/app/index.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@evidolob evidolob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just a few comments.

src/tkn.ts Outdated Show resolved Hide resolved
src/webview/pipeline/app/widgets/inputwidget.ts Outdated Show resolved Hide resolved
@sudhirverma
Copy link
Contributor Author

@evidolob done the changes

@sudhirverma sudhirverma merged commit 04f0059 into redhat-developer:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Webview to start pipeline.
3 participants