-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline wizard #338
Pipeline wizard #338
Conversation
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
==========================================
- Coverage 74.58% 72.92% -1.66%
==========================================
Files 49 52 +3
Lines 3427 3550 +123
Branches 616 642 +26
==========================================
+ Hits 2556 2589 +33
- Misses 871 961 +90
Continue to review full report at Codecov.
|
Workspace UI @siamaksade and @evidolob |
dd8146d
to
e0e9cb8
Compare
@sudhirverma I got: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will continue review when I will able to test this
@sudhirverma I have empty wizard for this pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to reorganize folder structure:
- Rename
element
folder towidgets
- move
navigation.ts
towidgets
- move
widget.ts
towidgets
if YAML doesn't have params, git or image resources, and workspace I will directly start the pipeline. without showing the wizard. |
@siamaksade and @evidolob param, git and Image Resource Gif Workspace Gif |
Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
@sudhirverma When wizard starts pipeline, it is open pipeline run diagram for previous pipelinerun: |
okay, I will check this out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, just a few comments.
@evidolob done the changes |
Fix: #310