-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show condition run as child for taskrun #292
Conversation
Signed-off-by: Yevhen Vydolob <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Yevhen Vydolob <[email protected]>
@siamaksade I had to introduce new state icon for task in pipelinerun, which indicates that task is pending, and it will show icon for canceled task(we already have it) WDYT? And another question that with this PR, it is possible to click on 'Open in editor' icon for task, which always throw error until task is not started. As we relay on information provided by pipelinerun json/yaml, which contains all commands, but corresponding TaskRun will not appear until task start running. |
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
==========================================
- Coverage 74.12% 73.44% -0.68%
==========================================
Files 44 44
Lines 3142 3216 +74
Branches 565 583 +18
==========================================
+ Hits 2329 2362 +33
- Misses 813 854 +41
Continue to review full report at Codecov.
|
Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob the pending icon looks good, and better representative of that state of pipelinerun. Could we also use a different icon for the condition? About "Open in Editor", showing and error is fine. The error message should explain that the taskrun is not started yet and user can open it in the editor as soon as it starts running. |
@siamaksade Yes we can, I'm not sure which one to use. As in general condition is also taskrun, and may have same states as regular taskrun. |
…to condition-as-child Signed-off-by: Yevhen Vydolob <[email protected]>
I think we can use our icons for other resources(with abbreviation ) and change colors of it depending on state(success/fail/pending/canceled) |
Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
As side effect of this PR, tree load for PipelineRun and it child become more faster,
now we use only PipelineRun data to build subtree for pipelinerun,
previously we fetch TaskRun's for each PipelineRun
Example:
Fix: #277