Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of pipelineruns and taskruns in a tree #127

Merged
merged 3 commits into from
Jan 14, 2020
Merged

Conversation

evidolob
Copy link
Collaborator

This PR add limit on number of tree item for pipelineruns and taskruns, by default limit is 5 but can be changed in a preferences(treePaginationLimit option)

Also this PR changes the way how pipelineruns and taskruns are sorted and listed in a tree.
Now all of them sorted by creation time and newest showing first.

Demo:
ezgif com-resize

Fix for: #79

@codecov-io
Copy link

codecov-io commented Jan 13, 2020

Codecov Report

Merging #127 into master will decrease coverage by 0.13%.
The diff coverage is 74.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage    74.4%   74.26%   -0.14%     
==========================================
  Files          19       19              
  Lines        1090     1127      +37     
  Branches      157      164       +7     
==========================================
+ Hits          811      837      +26     
- Misses        279      290      +11
Impacted Files Coverage Δ
src/extension.ts 86.74% <100%> (+0.49%) ⬆️
src/tkn.ts 77.8% <72.5%> (-0.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 673b5b9...8f557fd. Read the comment docs.

@siamaksade
Copy link

/lgtm

Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob evidolob merged commit 0babd12 into master Jan 14, 2020
@evidolob evidolob deleted the limit-number branch January 14, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants