Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tekton.edit error when clicking on the "Open in Editor" icon #296

Closed
lstocchi opened this issue May 21, 2020 · 10 comments · Fixed by #327
Closed

Tekton.edit error when clicking on the "Open in Editor" icon #296

lstocchi opened this issue May 21, 2020 · 10 comments · Fixed by #327
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@lstocchi
Copy link
Contributor

i get this error
image

when clicking on any of the Open in Editor icon you find on the right of a tree item
image

By clicking on the name of the resource works fine so it's just the icon

@evidolob
Copy link
Collaborator

That strange, I use that command every day and never see that error, can you provide additional information?

@lstocchi
Copy link
Contributor Author

lstocchi commented May 21, 2020

@evidolob I made some test and found out that if the server connector extension is installed i get this error, otherwise it works fine. It would be great if you could install https://marketplace.visualstudio.com/items?itemName=redhat.vscode-server-connector and try to replicate it. If we both have this kind of issue, we can try to investigate about it and maybe have an idea if it happens again in future. Or maybe we need to change something in the code. I worked on the server connector extension so if there is something wrong i can handle it immediately.

@evidolob
Copy link
Collaborator

evidolob commented May 21, 2020

I install server connector and Open in Editor still works.
Error that you describe is very strange, that can happen only in if tekton extension is not register handler for tekton.edit command, it can be but, rest of extension should not work either.
Can you look in Log (Extension Host) in 'Output' view, maybe there some errors

@evidolob evidolob reopened this May 21, 2020
@lstocchi
Copy link
Contributor Author

lstocchi commented May 21, 2020

What if you uninstall tekton extenstion and then reinstall it (with the server connector already installed)? Still works fine for you?

BTW yeah it's very strange.

@evidolob
Copy link
Collaborator

I usually don't have tecton extension installed, I use it from dev mode. But for your ask, I test both cases, first install server connector then run dev mode with tekton extension - all work. Then install tekton extension from marketplace and test then all work also.

@evidolob
Copy link
Collaborator

Btw, I don't have any server running/installed for server connector, maybe that the case?

@lstocchi
Copy link
Contributor Author

I looked in the Log (Extension Host). Nothing wrong apparently.
I don't know what is the issue, i'll keep investigating and let you know if i discover something.

I don't think it is related to having any server installed. I don't start any rsp server. Just open vscode, go to the tekton tab and click on "open in editor" icon of some random resource. No idea seriously.

@lstocchi
Copy link
Contributor Author

Closing this for the moment and i'll reopen it if i have some more info. Thanks @evidolob

@sudhirverma
Copy link
Contributor

I also install server connector and start server but not getting an error while opening the editor from the icon.

@lstocchi lstocchi reopened this May 28, 2020
@lstocchi
Copy link
Contributor Author

lstocchi commented May 28, 2020

I had some time to look into this and i found something. There are still some aspects which i need to clarify like "why did it work when i remove server connector?". Maybe i was playing with intellij or i was on Windows, i don't remember but i'll keep investigating.

BTW back to the issue. If i remove tekton from the path the extension use (in my case ~/.vs-tekton/tkn), it will ask me if i want to download and install it
image

The problem is that the code is stuck on this popup (if i don't click on anything) and it doesn't register any command.

response = await vscode.window.showInformationMessage(
            `Cannot find Tekton CLI ${ToolsConfig.tool['tkn'].versionRangeLabel} for interacting with Tekton Pipelines.`, installRequest, 'Help', 'Cancel');

but i can correctly see and navigate the tree
image

so if i try to execute any command (in my case opening the config of a resource), i get the error message
image

@sudhirverma sudhirverma added the kind/bug Something isn't working label May 28, 2020
@sudhirverma sudhirverma added this to the Sprint #185 milestone May 28, 2020
@evidolob evidolob self-assigned this Jun 16, 2020
evidolob added a commit that referenced this issue Jun 17, 2020
@evidolob evidolob modified the milestones: Sprint #185, Sprint #186 Jun 24, 2020
evidolob added a commit that referenced this issue Jun 26, 2020
* #296 do not block extension activation with 'tkn' detection

Signed-off-by: Yevhen Vydolob <[email protected]>

* Disable all 'tkn' commands if proper tkn is not installed

Signed-off-by: Yevhen Vydolob <[email protected]>

* fix tkn detection

Signed-off-by: Yevhen Vydolob <[email protected]>

* fix test

Signed-off-by: Yevhen Vydolob <[email protected]>

* Udate message

Signed-off-by: Yevhen Vydolob <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants