Fix test

redhat-developer · Jun 23, 2020 · bff3ff0 · bff3ff0
1 parent 96cdb44
commit bff3ff0
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/src/tekton/pipeline.ts b/src/tekton/pipeline.ts
@@ -26,7 +26,7 @@ export class Pipeline extends TektonItem {
   static async start(pipeline: TektonNode): Promise<string> {
     if (Pipeline.checkWebViewStartPipeline()) {
       pipelineViewLoader.loadView('Start Pipeline', await pipelineData(pipeline.getName()));
-      return;
+      return null;
     }
     if (!pipeline) {
       pipeline = await window.showQuickPick(await Pipeline.getPipelineNames(), {placeHolder: 'Select Pipeline to start', ignoreFocusOut: true});

diff --git a/test/tekton/pipeline.test.ts b/test/tekton/pipeline.test.ts
@@ -34,6 +34,7 @@ suite('Tekton/Pipeline', () => {
 
   setup(() => {
     execStub = sandbox.stub(TknImpl.prototype, 'execute').resolves({ error: null, stdout: '', stderr: '' });
+    sandbox.stub(Pipeline, 'checkWebViewStartPipeline').returns(false);
     showQuickPickStub = sandbox.stub(vscode.window, 'showQuickPick').resolves(undefined);
     sandbox.stub(TknImpl.prototype, 'getPipelines').resolves([pipelineItem]);
     getPipelineStub = sandbox.stub(TektonItem, 'getPipelineNames').resolves([pipelineItem]);

diff --git a/test/tekton/pipelinecontent.test.ts b/test/tekton/pipelinecontent.test.ts
@@ -131,7 +131,7 @@ suite('PipelineContent', () => {
       const result = await PipelineContent.startObject(pipelineTrigger, 'pipeline');
       expect(result).deep.equals({
         name: 'build-and-deploy',
-        params: [
+        parameters: [
           {
             default: undefined,
             description: 'name of the deployment to be patched',
@@ -164,7 +164,7 @@ suite('PipelineContent', () => {
       const result = await PipelineContent.startObject(pipelineTrigger, 'pipeline');
       expect(result).deep.equals({
         name: 'build-and-deploy',
-        params: [
+        parameters: [
           {
             default: {
               label: 'params-data'
@@ -240,7 +240,7 @@ suite('PipelineContent', () => {
       const result = await PipelineContent.startObject(workspace, 'pipeline');
       expect(result).deep.equals({
         name: 'fetch-and-print-recipe',
-        params: [],
+        parameters: [],
         resources: [],
         serviceAccount: undefined,
         workspaces: [
@@ -282,7 +282,7 @@ suite('PipelineContent', () => {
       const result = await PipelineContent.startObject(serviceTrigger, 'pipeline');
       expect(result).deep.equals({
         name: 'build-and-deploy',
-        params: [],
+        parameters: [],
         resources: [],
         serviceAccount: 'service',
         workspaces: []
@@ -295,7 +295,7 @@ suite('PipelineContent', () => {
       const result = await PipelineContent.startObject(serviceTrigger, 'pipeline');
       expect(result).deep.equals({
         name: 'build-and-deploy',
-        params: [],
+        parameters: [],
         resources: [],
         serviceAccount: 'service',
         workspaces: []