Improve ollama startup script for linux #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
force-pushed
the
improve-ollama-linux-startup
branch
from
f86d6ab to
ebae717
Compare
fbricon
force-pushed
the
improve-ollama-linux-startup
branch
2 times, most recently
from
6798093 to
14f4bf1
Compare
halfline
reviewed
Dec 18, 2024
There was a problem hiding this comment.
Overall, this is a nice clean up. It makes the script much tidier than it was before, but I wouldn't really say the script is more optimized (at least optimize is a loaded word that usually connotes runtime efficiency).
I'd change the commit message to something like this
start_ollama.sh: Refactor Ollama startup script for readability
The start_ollama.sh script is used by paver on Linux to help ensure
ollama gets started if it's not already running.
The script is functional, but largely open coded, and can be improved
for readability and maintainability sake.
This commit makes a few changes to improve the script:
- Introduce `readonly` constants for timeout and API endpoint URL
- Add and use helper functions (`ollama_is_running()`, `in_container()`, `command_exists()`) for legibility
- Add `main()` function entry point
0837a30 to
afe38d3
Compare
fbricon
changed the title
The start_ollama.sh script is used by paver on Linux to help ensure ollama gets started if it's not already running. The script is functional, but largely open coded, and can be improved for readability and maintainability sake. This commit makes a few changes to improve the script: - Introduce `readonly` constants for timeout and API endpoint URL - Add and use helper functions (`ollama_is_running()`, `in_container()`, `command_exists()`) for legibility - Add `main()` function entry point Signed-off-by: Fred Bricon <[email protected]>
fbricon
force-pushed
the
improve-ollama-linux-startup
branch
from
afe38d3 to
a3e806c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fred Bricon [email protected]