Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the advanced section, for selecting the tab completion #144

Conversation

SachinS10-lab
Copy link
Contributor

Added toggle button for advanced section.

Image


For Simple Configuration

Image


For Advanced Configuration

Image


I also add an information message below the box for better user experience. Is this Okay?

Image

@fbricon
Copy link
Collaborator

fbricon commented Nov 18, 2024

Please reread the instructions in #137

the advanced section, where the tab completion can be selected?

@SachinS10-lab
Copy link
Contributor Author

Please reread the instructions in #137

the advanced section, where the tab completion can be selected?

Okay, I understand. I simplified the code to become only one combobox for both selections. Will change that.

@SachinS10-lab
Copy link
Contributor Author

Added the tab completion combo in the advanced section.

image

Simple section.

image

options={modelOptions}
progress={chatModel ? modelPullProgress[chatModel] : undefined}
disabled={!enabled}
tooltip="This model will be used for Chat and Tab Completion"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This model will be used for Chat

status={getModelStatus(tabModel)}
options={tabOptions}
progress={tabModel ? modelPullProgress[tabModel] : undefined}
disabled={!enabled}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tooltip="This model will be used for Tab Completion"

@fbricon
Copy link
Collaborator

fbricon commented Nov 18, 2024

See comments in screenshot

Screenshot 2024-11-18 at 14 35 35

@SachinS10-lab
Copy link
Contributor Author

See comments in screenshot

Screenshot 2024-11-18 at 14 35 35

Will do that.

@fbricon
Copy link
Collaborator

fbricon commented Nov 18, 2024

also, the 1st information message should have a single *.
The new one can have 2 *

@fbricon
Copy link
Collaborator

fbricon commented Nov 19, 2024

FTR, the build is still broken

Signed-off-by: sachinsuresh-s10 <[email protected]>
@SachinS10-lab
Copy link
Contributor Author

Hi @fbricon,
In App.test.tsx, the tabModelId is accepting only null value. Due to that Build is failing. I'm working on it.

…fault value for build error fixing

Signed-off-by: sachinsuresh-s10 <[email protected]>
@SachinS10-lab
Copy link
Contributor Author

Hi @fbricon,
I'm adding a new PR for this fix. I accidently pushed package.json files in this PR.

New PR: #149

@fbricon fbricon closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants