-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the advanced section, for selecting the tab completion #144
Added the advanced section, for selecting the tab completion #144
Conversation
Signed-off-by: sachinsuresh-s10 <[email protected]>
Please reread the instructions in #137
|
Okay, I understand. I simplified the code to become only one combobox for both selections. Will change that. |
Signed-off-by: sachinsuresh-s10 <[email protected]>
options={modelOptions} | ||
progress={chatModel ? modelPullProgress[chatModel] : undefined} | ||
disabled={!enabled} | ||
tooltip="This model will be used for Chat and Tab Completion" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This model will be used for Chat
webviews/src/App.tsx
Outdated
status={getModelStatus(tabModel)} | ||
options={tabOptions} | ||
progress={tabModel ? modelPullProgress[tabModel] : undefined} | ||
disabled={!enabled} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tooltip="This model will be used for Tab Completion"
Signed-off-by: sachinsuresh-s10 <[email protected]>
Signed-off-by: sachinsuresh-s10 <[email protected]>
also, the 1st information message should have a single *. |
Signed-off-by: Fred Bricon <[email protected]>
Signed-off-by: sachinsuresh-s10 <[email protected]>
FTR, the build is still broken |
Signed-off-by: sachinsuresh-s10 <[email protected]>
Hi @fbricon, |
…fault value for build error fixing Signed-off-by: sachinsuresh-s10 <[email protected]>
Added toggle button for advanced section.
For Simple Configuration
For Advanced Configuration
I also add an information message below the box for better user experience. Is this Okay?