-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate Tab completion reliability #110
Comments
I can confirm this is several ways:
When model queries happen there's no suggestion in the editor There are instructions for the case where you dont have these: https://docs.continue.dev/customize/deep-dives/autocomplete#im-not-seeing-any-completions |
Please try again with The tags fp16 is also faster response and may help. |
Hi @jamescho72 |
Afaics the majority of cases where no suggestions are shown are caused by suggestion filtering in continue. I stumbled upon other cases, too but couldn't replicate them though. More digging is needed. A suggestion returned by the model is ignored if it is repeating previous or following lines: if (lineIsRepeated(nextLine, trimmedLine)) {
fullStop();
break;
} if (line === previousLine) {
repeatCount++;
if (repeatCount === MAX_REPEATS) {
fullStop();
return;
} Screen.Recording.2024-11-25.at.15.58.14.mov |
Fred and I aren't able to get consistent results out of 2b either, I would use granite3-dense:8b for tab completion. |
According to my findings in code, the quality of the model (the suggestion provided by the model to be more precise) has an effect. I'll switch to 8b then. |
I'm currently trying to figure why a suggestion provided by granite isn't displayed: Steps:
class Calculator {
constructor() {
this.result = 0;
}
add(number) {
this.result += number;
return this;
}
subtract(number) {
this.result -= number;
return this;
}
multiply(number) {
this.result *= number;
return this;
}
divide(number) {
if (number === 0) {
throw new Error("Cannot divide by zero");
}
this.result /= number;
return this;
}
getResult() {
return this.result;
}
reset() {
this.result = 0;
return this;
}
}
Result: Screen.Recording.2024-11-28.at.15.43.09.movThe suggestion disappears as soon as you hit throw new Error("Cannot divide by zero"); But this suggestion isn't displayed. It's cached though and if you get back to the prior line the suggestion is displayed there. |
PR continuedev/continue#3128 fixed the problem described at #110 (comment) |
To me, latest main branch behaves quite consistently. I didn't spot major flaws lately: Screen.Recording.2024-12-03.at.15.22.17.mov |
I found that tabCompletion was not reliable with Granite models, eg. I could see some Completion: result being returned from the
Continue LLM Prompt/Completion
output view, but not proposed as tab completion.We may need to fine tune tabAutocompleteOptions, see https://docs.continue.dev/customize/deep-dives/autocomplete#configuration-options and/or there might be some integration issue with Granite, in upstream Continue code, that'd need some love.
The text was updated successfully, but these errors were encountered: